chore(NA): moving @kbn/monaco into bazel #100709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
reviewed
May 26, 2021
|
@elasticmachine merge upstream |
|
@jbudz webpack is being run differently as I'm always running it within a prod environment right now. It might have to do with it I think. |
jbudz
approved these changes
May 26, 2021
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
May 27, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 27, 2021
* chore(NA): moving @kbn/monaco into bazel * chore(NA): update register globals definitions * chore(NA): remove build script Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 27, 2021
* chore(NA): moving @kbn/monaco into bazel * chore(NA): update register globals definitions * chore(NA): remove build script Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR moves the @kbn/monaco into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.