Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SO migrationsv2] Explicitly transition to a cleanup phase before migration fails #100953

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented May 28, 2021

[On Hold]

Summary

Resolves #100650
Main changed to the model:

  • transition to CLEANUP_FATAL before FATAL
  • transition to CLEANUP_BAD_RESPONSE before throwBadResponse

The only cleanup action performed at this stage is to close any remaining open pit search. For this reason, the transitions to CLEANUP_* before FATAL or throwBadResponse are only applied during relevant migration transitions.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios (partially updated)
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

For maintainers

@TinaHeiligers TinaHeiligers added enhancement New value added to drive a business result project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels May 28, 2021
@elastic elastic deleted a comment from kibanamachine May 28, 2021
@elastic elastic deleted a comment from kibanamachine May 28, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@TinaHeiligers TinaHeiligers deleted the so-migrationsv2/explicit_cleanup_step_attmpt1 branch July 21, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an explicit CLEANUP step to migrations v2
3 participants