[Monitoring] Pass zero to numeral if standalone cluster node count is unknown #101704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoristic
added
bug
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@elasticmachine merge upstream |
matschaffer
reviewed
Jun 22, 2021
| @@ -132,7 +132,7 @@ const getColumns = ( | |||
| 'data-test-subj': 'nodesCount', | |||
| sortable: true, | |||
| render: (total, cluster) => ( | |||
| <IsClusterSupported {...cluster}>{numeral(total).format('0,0')}</IsClusterSupported> | |||
| <IsClusterSupported {...cluster}>{numeral(total || 0).format('0,0')}</IsClusterSupported> | |||
There was a problem hiding this comment.
I think this could work, but it's sort of lying to you. I was thinking it might be better to swap in an "N/A" instead of inventing the zero.
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @matschaffer |
|
Looks like #103718 already includes a version of this change. Closing out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numerallibrary throws an error if passed an undefined value in SM clusters listhttps://kb-url:5601/app/monitoring#/home. The error is triggered if a standalone cluster (with undefined node count) shows up in the Stack Monitoring clusters list:This error breaks the SM ui