-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] Changes the telemetry banner dismiss location #102721
Conversation
Pinging @elastic/kibana-qa (Team:QA) |
Closing modal in |
Nice catch. This means I can now add that in all tests so we can remove that edge case as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, ok if CI passes
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* change telemetry banner dismiss location * use dismissBanner method instead * Update _metricbeat_dashboard.js * Update _maps.ts * Update _maps.ts * Update _metricbeat_dashboard.js
* change telemetry banner dismiss location * use dismissBanner method instead * Update _metricbeat_dashboard.js * Update _maps.ts * Update _maps.ts * Update _metricbeat_dashboard.js
* change telemetry banner dismiss location * use dismissBanner method instead * Update _metricbeat_dashboard.js * Update _maps.ts * Update _maps.ts * Update _metricbeat_dashboard.js Co-authored-by: Marius Dragomir <marius-dr@users.noreply.github.com>
* change telemetry banner dismiss location * use dismissBanner method instead * Update _metricbeat_dashboard.js * Update _maps.ts * Update _maps.ts * Update _metricbeat_dashboard.js Co-authored-by: Marius Dragomir <marius-dr@users.noreply.github.com>
This PR changes the test in which we dismiss the telemetry banner, in order to allow for multiple visual comparison tests in the stack_functional_tests.
Currently it was dismissed in 2 locations: maps test and metricbeat_dashboards test. If both tests run on the same VM it will fail since one of them won't be able to find the "Dismiss" button.
After this the dismiss will be done in the after step for the telemetry test. This way it will always be removed and won't influence any further tests.