Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Changes the telemetry banner dismiss location #102721

Merged
merged 6 commits into from
Jun 21, 2021
Merged

Conversation

marius-dr
Copy link
Member

This PR changes the test in which we dismiss the telemetry banner, in order to allow for multiple visual comparison tests in the stack_functional_tests.
Currently it was dismissed in 2 locations: maps test and metricbeat_dashboards test. If both tests run on the same VM it will fail since one of them won't be able to find the "Dismiss" button.

After this the dismiss will be done in the after step for the telemetry test. This way it will always be removed and won't influence any further tests.

@marius-dr marius-dr added Team:QA Team label for QA Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-stack-integration v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.13.3 labels Jun 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@marius-dr marius-dr requested review from LeeDr and dmlemeshko June 21, 2021 11:15
@dmlemeshko
Copy link
Member

Closing modal in after those 2 tests will fail again as soon as we skip the telemetry one (edge case, but still can happen)
There is a method dismissBanner() in common page, that I think can be put in place of await find.clickByButtonText('Dismiss');

@marius-dr
Copy link
Member Author

Closing modal in after those 2 tests will fail again as soon as we skip the telemetry one (edge case, but still can happen)
There is a method dismissBanner() in common page, that I think can be put in place of await find.clickByButtonText('Dismiss');

Nice catch. This means I can now add that in all tests so we can remove that edge case as well.

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, ok if CI passes

@marius-dr marius-dr enabled auto-merge (squash) June 21, 2021 16:39
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@marius-dr marius-dr merged commit 3662cf4 into master Jun 21, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
* change telemetry banner dismiss location

* use dismissBanner method instead

* Update _metricbeat_dashboard.js

* Update _maps.ts

* Update _maps.ts

* Update _metricbeat_dashboard.js
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
* change telemetry banner dismiss location

* use dismissBanner method instead

* Update _metricbeat_dashboard.js

* Update _maps.ts

* Update _maps.ts

* Update _metricbeat_dashboard.js
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 21, 2021
* change telemetry banner dismiss location

* use dismissBanner method instead

* Update _metricbeat_dashboard.js

* Update _maps.ts

* Update _maps.ts

* Update _metricbeat_dashboard.js

Co-authored-by: Marius Dragomir <marius-dr@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jun 21, 2021
* change telemetry banner dismiss location

* use dismissBanner method instead

* Update _metricbeat_dashboard.js

* Update _maps.ts

* Update _maps.ts

* Update _metricbeat_dashboard.js

Co-authored-by: Marius Dragomir <marius-dr@users.noreply.github.com>
@marius-dr marius-dr deleted the fix_telemetry_banner branch June 22, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test-stack-integration v7.13.3 v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants