Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [canvas] Reduce bundle size by combining SCSS imports (#102822) #103805

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

clintandrewhall
Copy link
Contributor

Backports the following commits to 7.x:

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/canvas/public/components/var_config/var_config.tsx
@clintandrewhall clintandrewhall enabled auto-merge (squash) June 30, 2021 04:33
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1106 1043 -63

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB -21.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 461.7KB 461.7KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit d7d3aa2 into elastic:7.x Jun 30, 2021
@clintandrewhall clintandrewhall deleted the backport/7.x/pr-102822 branch July 9, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants