Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Unskip flaky test when downloading CSV with "no data" #105252

Merged
merged 10 commits into from
Jul 20, 2021
+6 −2
Merged

[Reporting] Unskip flaky test when downloading CSV with "no data" #105252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
640f3c2
unskipped test and added additional checks when using time picker
jloleysens Jul 12, 2021
8631812
rather wait for the timepicker to close
jloleysens Jul 13, 2021
98a125b
set up test for flaky test runner
jloleysens Jul 13, 2021
e74a7c7
Additional .only
jloleysens Jul 13, 2021
98da65e
Merge branch 'master' into reporting/fix-flaky-test-csv-no-data
kibanamachine Jul 13, 2021
c5cd404
Remove .only
jloleysens Jul 14, 2021
3f1c0f5
Merge branch 'master' into reporting/fix-flaky-test-csv-no-data
kibanamachine Jul 14, 2021
bee98e5
Merge branch 'master' into reporting/fix-flaky-test-csv-no-data
kibanamachine Jul 15, 2021
207e3d2
Merge branch 'master' into reporting/fix-flaky-test-csv-no-data
kibanamachine Jul 16, 2021
3506749
Merge branch 'master' into reporting/fix-flaky-test-csv-no-data
kibanamachine Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/functional/page_objects/time_picker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ export class TimePickerPageObject extends FtrService {
await this.testSubjects.click('superDatePickerAbsoluteTab');
await this.testSubjects.click('superDatePickerAbsoluteDateInput');
await this.inputValue('superDatePickerAbsoluteDateInput', fromTime);
await this.browser.pressKeys(this.browser.keys.ESCAPE);

await this.retry.waitFor('Timepicker popover to close', async () => {
return !(await this.testSubjects.exists('superDatePickerAbsoluteDateInput'));
});

const superDatePickerApplyButtonExists = await this.testSubjects.exists(
'superDatePickerApplyTimeButton'
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/discover/reporting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/104372
describe.skip('Generate CSV: new search', () => {
describe('Generate CSV: new search', () => {
beforeEach(async () => {
await kibanaServer.importExport.load(ecommerceSOPath);
await PageObjects.common.navigateToApp('discover');
Expand Down