[TSVB] Add more functional tests for Gauge and TopN #105361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DianaDerevyankina
added
Feature:TSVB
VladLasitsa
reviewed
Jul 16, 2021
Comment on lines
362
to
374
| await this.visChart.waitForVisualizationRenderingStabilized(); | ||
| const [, gaugeColoredCircle] = await this.find.allByCssSelector( | ||
| '[data-test-subj="tvbVisGaugeContainer"] circle' | ||
| ); | ||
| return await gaugeColoredCircle.getAttribute('stroke'); | ||
| } | ||
|
|
||
| public async getGaugeInnerColor(): Promise<string> { | ||
| await this.visChart.waitForVisualizationRenderingStabilized(); | ||
| const gaugeInnerCircle = await this.find.byCssSelector( | ||
| '[data-test-subj="tvbVisGaugeContainer"] circle' | ||
| ); | ||
| return await gaugeInnerCircle.getAttribute('stroke'); |
There was a problem hiding this comment.
I think we can union these methods.
VladLasitsa
reviewed
Jul 16, 2021
Comment on lines
759
to
764
| public async setFilterRatioNumerator(numerator: string) { | ||
| const numeratorInput = await this.find.byCssSelector( | ||
| '.tvbAggRow [data-test-subj="queryInput"]' | ||
| ); | ||
| await numeratorInput.type(numerator); | ||
| } |
There was a problem hiding this comment.
we have this method in other PR (#105060)
alexwizp
reviewed
Jul 16, 2021
| public async getGaugeColor(): Promise<string> { | ||
| await this.visChart.waitForVisualizationRenderingStabilized(); | ||
| const [, gaugeColoredCircle] = await this.find.allByCssSelector( | ||
| '[data-test-subj="tvbVisGaugeContainer"] circle' |
There was a problem hiding this comment.
@VladLasitsa @dziyanadzeraviankina is it possible to avoid of using css selectors?
# Conflicts: # test/functional/apps/visualize/_tsvb_chart.ts
… visual_builder_page
|
@elasticmachine merge upstream |
alexwizp
reviewed
Jul 20, 2021
| @@ -358,6 +358,12 @@ export class VisualBuilderPageObject extends FtrService { | |||
| return await gaugeCount.getVisibleText(); | |||
| } | |||
|
|
|||
| public async getGaugeColor(type: undefined | 'Inner' = undefined): Promise<string> { | |||
There was a problem hiding this comment.
Am I right that we have only 2 cases 'Inner' and not-'Inner'. If it's true maybe we should use boolean instead?
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/nodes_mb·js.Monitoring app Elasticsearch nodes listing mb with only online nodes should filter for non-existent indexStandard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
alexwizp
approved these changes
Jul 21, 2021
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
approved these changes
Jul 21, 2021
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Jul 21, 2021
* [TSVB] Add more functional tests for Gauge and TopN * Update visual_builder_page.ts * Update functions related to gauge color and filter ratio numerator in visual_builder_page * Update visual_builder_page and add some more test subjects * Update _tsvb_chart.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 21, 2021
…y-show-migrate-to-authzd-users * 'master' of github.com:elastic/kibana: (48 commits) [Canvas] Expression shape (elastic#103219) [FTR] Skips Vega tests [Sample data] Use Lens in ecommerce data (elastic#106039) [APM] Backends inventory & overview page routes (elastic#106223) [TSVB] Add more functional tests for Gauge and TopN (elastic#105361) Add toggle to enable/disable rule install from SOs (elastic#106189) Improve unit test coverage of FS API calls (elastic#106242) Remove recursive plugin status in meta field (elastic#106286) [Ingest pipelines] add community id processor (elastic#103863) [XY axis] Fixes the values inside bar charts (elastic#106198) [data.search] Set default expiration to 1m if search sessions are disabled (elastic#105329) set the doc title when navigating to reporting and unset when navigating away (elastic#106253) [Lens] Display legend inside chart (elastic#105571) [RAC] [TGrid] Migrate the TGrid's rendering to `EuiDataGrid` (elastic#106199) [Security Solutions] Removes the elastic legacy client from lists and security_solution plugins (elastic#106130) [Enterprise Search] Require security plugin in 8.0 (elastic#106307) [DOCS] Updates screenshots in Dev Tools docs (elastic#105859) [DOCS] Updates text and screenshots in tags doc (elastic#105853) [Alerting] Allow rule types to extract/inject saved object references on rule CRU (elastic#101896) Jest and Storybook fixes (elastic#104991) ... # Conflicts: # x-pack/plugins/reporting/public/plugin.ts
DianaDerevyankina
added a commit
that referenced
this pull request
Jul 21, 2021
* [TSVB] Add more functional tests for Gauge and TopN * Update visual_builder_page.ts * Update functions related to gauge color and filter ratio numerator in visual_builder_page * Update visual_builder_page and add some more test subjects * Update _tsvb_chart.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added functional tests for TSVB
GaugeandTopNcovering cases mentioned here (#102606)For maintainers