Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v33 (master) #105633

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Update dependency @elastic/charts to v33 (master) #105633

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2a7ee7
Update dependency @elastic/charts to v33
renovate-bot Jul 14, 2021
720d90e
Merge branch 'master' into renovate/master-@elasticcharts
kibanamachine Jul 16, 2021
66f4bac
update breaking changes
nickofthyme Jul 16, 2021
283dab5
Merge branch 'master' into renovate/master-@elasticcharts
kibanamachine Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"dependencies": {
"@elastic/apm-rum": "^5.8.0",
"@elastic/apm-rum-react": "^1.2.11",
"@elastic/charts": "32.0.0",
"@elastic/charts": "33.0.0",
"@elastic/datemath": "link:bazel-bin/packages/elastic-datemath",
"@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@^8.0.0-canary.13",
"@elastic/ems-client": "7.14.0",
Expand Down
5 changes: 3 additions & 2 deletions src/plugins/vis_type_xy/public/utils/render_all_series.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
Accessor,
AccessorFn,
ColorVariant,
LabelOverflowConstraint,
} from '@elastic/charts';

import { DatatableRow } from '../../../expressions/public';
Expand Down Expand Up @@ -130,7 +131,7 @@ export const renderAllSeries = (
minBarHeight={2}
displayValueSettings={{
showValueLabel,
hideClippedValue: true,
overflowConstraints: [LabelOverflowConstraint.ChartEdges],
}}
/>
);
Expand Down Expand Up @@ -161,7 +162,7 @@ export const renderAllSeries = (
stackAccessors={isStacked ? ['__any_value__'] : undefined}
displayValueSettings={{
showValueLabel,
hideClippedValue: true,
overflowConstraints: [LabelOverflowConstraint.ChartEdges],
}}
timeZone={timeZone}
stackMode={stackMode}
Expand Down
32 changes: 24 additions & 8 deletions x-pack/plugins/lens/public/xy_visualization/__snapshots__/expression.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion x-pack/plugins/lens/public/xy_visualization/expression.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
ElementClickListener,
BrushEndListener,
CurveType,
LabelOverflowConstraint,
} from '@elastic/charts';
import { I18nProvider } from '@kbn/i18n/react';
import {
Expand Down Expand Up @@ -909,7 +910,7 @@ export function XYChart({
showValueLabel: shouldShowValueLabels && valueLabels !== 'hide',
isAlternatingValueLabel: false,
isValueContainedInElement: true,
hideClippedValue: true,
overflowConstraints: [LabelOverflowConstraint.ChartEdges],
},
};
return <BarSeries key={index} {...seriesProps} {...valueLabelsSettings} />;
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,10 +1389,10 @@
dependencies:
object-hash "^1.3.0"

"@elastic/charts@32.0.0":
version "32.0.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-32.0.0.tgz#f747b8fa931027ba7476a6284be03383cd6a6dab"
integrity sha512-3cvX0Clezocd6/T2R5h3+nilPdIgWrO+it043giyW5U0pAtFC5P+5VyNEjn22LlD3zzbndxAbXHSj0QDvHXOBw==
"@elastic/charts@33.0.0":
version "33.0.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-33.0.0.tgz#45428b792300e363ecd3454465be49d42788a1fd"
integrity sha512-HUt0oBaO/PSRZcYHmdLL1lzFWMBtP/9umGIAQgW785qv+y/Hv2cjjfYNckGfnr5RUDtx0KCc3v2UBkRq6n93EA==
dependencies:
"@popperjs/core" "^2.4.0"
chroma-js "^2.1.0"
Expand Down