chore(NA): improves @kbn/ui-shared-deps build performance #105971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared-deps-performance
…ared-deps-performance
…ared-deps-performance
…ared-deps-performance
…ared-deps-performance
mistic
added
chore
Team:Operations
mistic
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
jbudz
reviewed
Jul 19, 2021
spalger
reviewed
Jul 19, 2021
jbudz
reviewed
Jul 19, 2021
|
In development mode. Left side is master, noting the 404's on sourcemaps. This is on Windows, but I expect it's on both Otherwise, bundles in production LGTM. Size matches the previously minified versions. |
|
@jbudz I've included the source-maps, could you check if that worked? |
|
f995b69 fixed the source map issues. |
…ared-deps-performance
jbudz
approved these changes
Jul 20, 2021
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jul 21, 2021
…5971) * chore(NA): move packages assets optimization into the distributable build * chore(NA): include terser task on distributable build * chore(NA): migrate everything into the build tasks * chore(NA): update webpack config to include react profiler * chore(NA): optional fsevents * chore(NA): redo optional fsevents * chore(NA): remove noparse for fsevents * chore(NA): include missing task declaration * chore(NA): include sourcemaps * chore(NA): include metrics bundle file generation during distributable build * chore(NA): correctly setup paths * chore(NA): change sourcemap types * chore(NA): remove useless sourcemaps Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/scripts/jenkins_build_kibana.sh
mistic
added a commit
that referenced
this pull request
Jul 21, 2021
…106472) * chore(NA): move packages assets optimization into the distributable build * chore(NA): include terser task on distributable build * chore(NA): migrate everything into the build tasks * chore(NA): update webpack config to include react profiler * chore(NA): optional fsevents * chore(NA): redo optional fsevents * chore(NA): remove noparse for fsevents * chore(NA): include missing task declaration * chore(NA): include sourcemaps * chore(NA): include metrics bundle file generation during distributable build * chore(NA): correctly setup paths * chore(NA): change sourcemap types * chore(NA): remove useless sourcemaps Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/scripts/jenkins_build_kibana.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #69706 and #104519
This PR closes #104253
It removes the minification and the compression tasks from
@kbn/ui-shared-depsinto the distributable build pipeline which increases the bootstrap performance in more than ~60% without any cache.Also re-introduces React Profiler in development.