[Dashboard] Allow Reporting after Discarding Unsaved Changes #106026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
added
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
crob611
approved these changes
Jul 20, 2021
| @@ -329,6 +335,7 @@ export const useDashboardAppState = ({ | |||
| if (refreshInterval) timefilter.setRefreshInterval(refreshInterval); | |||
| } | |||
| dispatchDashboardStateChange(setDashboardState(lastSavedState)); | |||
| // setDashboardAppState((s) => ({ ...s, hasUnsavedChanges: false })); | |||
There was a problem hiding this comment.
Probably want to remove this comment?
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 20, 2021
…#106026) Allowed dashboard diffing to happen in view mode to fix dashboard unsaved changes not updating after discard changes
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 20, 2021
…#106026) Allowed dashboard diffing to happen in view mode to fix dashboard unsaved changes not updating after discard changes
ThomThomson
added a commit
that referenced
this pull request
Jul 20, 2021
#106314) Allowed dashboard diffing to happen in view mode to fix dashboard unsaved changes not updating after discard changes
ThomThomson
added a commit
that referenced
this pull request
Jul 20, 2021
#106313) Allowed dashboard diffing to happen in view mode to fix dashboard unsaved changes not updating after discard changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #105807 by allowing the dashboard diff checker to update the unsaved changes badge even while in view mode.
For maintainers