[ML] Transforms: Add functional tests for UI permissions #106693

peteharverson · 2021-07-26T10:02:56Z

Summary

Adds functional tests for UI permissions on the Transforms page under Stack Management.

Checks permissions on the Transforms management page and edit transform flyout for the following users:

TRANSFORM_POWERUSER
TRANSFORM_VIEWER

High-level tests

For more details see test step descriptions.

With no data loaded

Displays elements on the Transforms list page correctly
Displays enabled / disabled Create first transform button

With data loaded

Displays elements on the Transforms list page correctly
Displays enabled / disabled Create new transform button
Displays created transform
Displays enabled / disabled actions menu
Displays controls in the edit transform correctly (for TRANSFORM_POWERUSER)

Part of #106113.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-07-26T10:02:58Z

Pinging @elastic/ml-ui (:ml)

pheyos · 2021-07-26T10:37:21Z

Checking test stability in a flaky test runner job ... 50 failures in 50 runs ❌
Looks like the action popover wasn't open so the Edit button couldn't be clicked. Not sure why it passed locally for me though 🤔

pheyos · 2021-07-26T16:22:06Z

Checking test stability after the change in a flaky test runner job ... 28 transform failures in 50 runs ❌

All the failures are about action menu entries not being available due to a closed actions popover, but no failure for the permission tests anymore. Looks like we need to apply the fix (use clickTransformRowActionWithRetry instead of clickTransformRowAction) to all place where the transform actions are used.

pheyos · 2021-07-27T10:07:39Z

Checking test stability after the latest changes in a flaky test runner job ... no failure in 50 runs ✔️

pheyos

LGTM 🎉

kibanamachine · 2021-07-27T12:19:28Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: bf97c80
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup8

Test Failures

Kibana Pipeline / general / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/get_all·ts.spaces api with security get all dual-privileges readonly user can access all spaces from space_1 "before all" hook in "dual-privileges readonly user can access all spaces from space_1"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: spaces api with security
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_legacy_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_dual_privileges_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_1_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_1_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_2_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_2_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_1_2_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_1_2_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_saved_objects_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_saved_objects_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_1_saved_objects_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_space_1_saved_objects_read_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [not_a_kibana_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_1_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_1_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_1_2_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_saved_objects_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_saved_objects_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_1_saved_objects_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_space_1_saved_objects_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_apm_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_machine_learning_admin]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_machine_learning_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_monitoring_user]
[00:04:33]           └-: get all
[00:04:33]             └-> "before all" hook in "get all"
[00:04:52]             └-: dual-privileges readonly user can access all spaces from space_1
[00:04:52]               └-> "before all" hook in "dual-privileges readonly user can access all spaces from space_1"
[00:04:52]               └-> "before all" hook in "dual-privileges readonly user can access all spaces from space_1"
[00:04:52]                 │ info [x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces] Loading "mappings.json"
[00:04:52]                 │ info [x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces] Loading "data.json"
[00:04:52]                 │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_001/CSdqgMwuQzuN00FiFHLT8w] deleting index
[00:04:52]                 │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_task_manager_8.0.0_001/SM12tgasQdCaA43i3dogkQ] deleting index
[00:04:52]                 │ info [x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces] Deleted existing index ".kibana_8.0.0_001"
[00:04:52]                 │ info [x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:04:52]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0] creating index, cause [auto(update api)], templates [], shards [1]/[1]
[00:04:52]                 └- ✖ fail: spaces api with security get all dual-privileges readonly user can access all spaces from space_1 "before all" hook in "dual-privileges readonly user can access all spaces from space_1"
[00:04:52]                 │       ResponseError: invalid_alias_name_exception: [invalid_alias_name_exception] Reason: Invalid alias name [.kibana_8.0.0]: an index or data streamexists with the same name as the alias
[00:04:52]                 │       at onBody (/dev/shm/workspace/parallel/20/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:337:23)
[00:04:52]                 │       at IncomingMessage.onEnd (/dev/shm/workspace/parallel/20/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:264:11)
[00:04:52]                 │       at endReadableNT (internal/streams/readable.js:1317:12)
[00:04:52]                 │       at processTicksAndRejections (internal/process/task_queues.js:82:21)
[00:04:52]                 │ 
[00:04:52]                 │

Stack Trace

ResponseError: invalid_alias_name_exception: [invalid_alias_name_exception] Reason: Invalid alias name [.kibana_8.0.0]: an index or data stream exists with the same name as the alias
    at onBody (/dev/shm/workspace/parallel/20/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:337:23)
    at IncomingMessage.onEnd (/dev/shm/workspace/parallel/20/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:264:11)
    at endReadableNT (internal/streams/readable.js:1317:12)
    at processTicksAndRejections (internal/process/task_queues.js:82:21) {
  meta: {
    body: { error: [Object], status: 400 },
    statusCode: 400,
    headers: {
      'x-elastic-product': 'Elasticsearch',
      'content-type': 'application/json;charset=utf-8',
      'content-length': '337'
    },
    meta: {
      context: null,
      request: [Object],
      name: 'elasticsearch-js',
      connection: [Object],
      attempts: 0,
      aborted: false
    }
  }
}

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	924.2KB	924.4KB	+244.0B

History

💚 Build #140792 succeeded b0c8e46
💔 Build #140666 failed 6d13874

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

qn895 · 2021-07-27T21:18:04Z

LGTM 🎉

walterra

LGTM

) * [ML] Transforms: Add functional tests for UI permissions * [ML] Fix for edit flyout action * [ML] Stabilize tests that open the actions menu

kibanamachine · 2021-07-28T08:28:31Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…106960) * [ML] Transforms: Add functional tests for UI permissions * [ML] Fix for edit flyout action * [ML] Stabilize tests that open the actions menu Co-authored-by: Pete Harverson <peteharverson@users.noreply.github.com>

) * [ML] Transforms: Add functional tests for UI permissions * [ML] Fix for edit flyout action * [ML] Stabilize tests that open the actions menu

[ML] Transforms: Add functional tests for UI permissions

6d13874

peteharverson added review :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.15.0 labels Jul 26, 2021

peteharverson requested review from walterra, pheyos and qn895 July 26, 2021 10:02

peteharverson self-assigned this Jul 26, 2021

peteharverson requested a review from a team as a code owner July 26, 2021 10:02

peteharverson mentioned this pull request Jul 26, 2021

[ML] Increase Test Coverage 7.15 #106113

Closed

14 tasks

[ML] Fix for edit flyout action

b0c8e46

[ML] Stabilize tests that open the actions menu

bf97c80

pheyos approved these changes Jul 27, 2021

View reviewed changes

qn895 approved these changes Jul 27, 2021

View reviewed changes

walterra approved these changes Jul 28, 2021

View reviewed changes

peteharverson added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 28, 2021

peteharverson merged commit f67737d into elastic:master Jul 28, 2021

peteharverson deleted the transforms-permissions-func-tests branch July 28, 2021 08:25

kibanamachine mentioned this pull request Jul 28, 2021

[7.x] [ML] Transforms: Add functional tests for UI permissions (#106693) #106960

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Transforms: Add functional tests for UI permissions #106693

[ML] Transforms: Add functional tests for UI permissions #106693

peteharverson commented Jul 26, 2021 •

edited

Loading

elasticmachine commented Jul 26, 2021

pheyos commented Jul 26, 2021 •

edited

Loading

pheyos commented Jul 26, 2021 •

edited

Loading

pheyos commented Jul 27, 2021 •

edited

Loading

pheyos left a comment

kibanamachine commented Jul 27, 2021

Standard Out

Stack Trace

qn895 commented Jul 27, 2021

walterra left a comment

kibanamachine commented Jul 28, 2021

[ML] Transforms: Add functional tests for UI permissions #106693

[ML] Transforms: Add functional tests for UI permissions #106693

Conversation

peteharverson commented Jul 26, 2021 • edited Loading

Summary

High-level tests

Checklist

elasticmachine commented Jul 26, 2021

pheyos commented Jul 26, 2021 • edited Loading

pheyos commented Jul 26, 2021 • edited Loading

pheyos commented Jul 27, 2021 • edited Loading

pheyos left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 27, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

History

qn895 commented Jul 27, 2021

walterra left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 28, 2021

💚 Backport successful

peteharverson commented Jul 26, 2021 •

edited

Loading

pheyos commented Jul 26, 2021 •

edited

Loading

pheyos commented Jul 26, 2021 •

edited

Loading

pheyos commented Jul 27, 2021 •

edited

Loading