Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Move APM Latency Correlations from flyout to transactions page. #107266

Merged
merged 61 commits into from
Aug 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
615e47e
[ML] Draft version of correlations being added to main pages.
walterra Jul 30, 2021
3327a6d
[ML] Add selection capability to latency histogram chart.
walterra Aug 3, 2021
2660d27
[ML] Adds button to toggle correlations visibility.
walterra Aug 3, 2021
2b36190
[ML] Improve chart refresh, adds option to load overall histogram only.
walterra Aug 3, 2021
69b38d2
remove percentileThresholdValue from client side params.
walterra Aug 4, 2021
a26728a
[ML] More fine grained latency range selection.
walterra Aug 4, 2021
bd5da21
[ML] Fix jest tests.
walterra Aug 5, 2021
f72cf18
[ML] Clear selection button.
walterra Aug 5, 2021
d696376
[ML] Fix to clear selection.
walterra Aug 5, 2021
2a3b719
[ML] Return trace samples based on chart selection.
walterra Aug 5, 2021
e92f017
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 9, 2021
bb39370
[ML] Move transaction content to tabs.
walterra Aug 9, 2021
f80382e
[ML] Fix correlation chart loading state.
walterra Aug 9, 2021
c80d301
[ML] Fix translation ids.
walterra Aug 9, 2021
16d9067
[ML] Selection UI tweaks.
walterra Aug 10, 2021
2057e48
[ML] Weight retainer tweak.
walterra Aug 10, 2021
93387f5
[ML] Adds current sample as marker to correlations chart.
walterra Aug 10, 2021
cc2479e
[ML] Tweak y axis ticks.
walterra Aug 10, 2021
9d60e99
[ML] Tweak EuiPanel layout. Fix translations ids.
walterra Aug 10, 2021
c487944
[ML] Set default table rows to 10.
walterra Aug 10, 2021
f330266
[ML] Fix i18n.
walterra Aug 10, 2021
5d541e4
[Ml] Remove outdated code.
walterra Aug 10, 2021
74f6a5e
[ML] Disable drag select for correlation analysis.
walterra Aug 10, 2021
1dffda8
[ML] Tweak vertical alignment.
walterra Aug 10, 2021
d8c04aa
[ML] Refactor to fetch samples without buckets only.
walterra Aug 10, 2021
70a0b52
[ML] Fix i18n.
walterra Aug 10, 2021
0a5fd53
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 11, 2021
a7ec3da
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 11, 2021
a76dcd2
[ML] Fix async search service to use state provider.
walterra Aug 11, 2021
0898e8b
[ML] Tweak trace samples API response. Fix API integration tests.
walterra Aug 11, 2021
7ba8225
[ML] Refactor tabs.
walterra Aug 11, 2021
93a5703
[ML] Add license gate to failed transactions.
walterra Aug 11, 2021
86d716b
[ML] Remove 'Correlations' button.
walterra Aug 11, 2021
f7dfc93
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 11, 2021
bf8a12e
[ML] Readd beta badge.
walterra Aug 12, 2021
22e11c3
[ML] Fix i18n.
walterra Aug 12, 2021
ed9f721
[ML] Remove flyout based correlations component.
walterra Aug 12, 2021
5f8c045
[ML] Rename correlations tab.
walterra Aug 12, 2021
a2564f5
[ML] Move beta badge to tab.
walterra Aug 12, 2021
a8df4e1
[ML] Fix i18n.
walterra Aug 12, 2021
207e0c1
[ML] Update functional tests.
walterra Aug 12, 2021
2c49566
Revert "[ML] Tweak y axis ticks."
walterra Aug 12, 2021
0e5e160
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 13, 2021
13b91a0
[ML] Tweak annotation id.
walterra Aug 13, 2021
94aa4f9
[ML] Refactor to get rid of 'params'.
walterra Aug 13, 2021
14c229d
[ML] Rename failed transactions tab.
walterra Aug 13, 2021
539102e
[ML] Refactor to have separate components for trace samples and laten…
walterra Aug 13, 2021
919cd6a
[ML] Tweak url parameters.
walterra Aug 13, 2021
03e450e
[ML] Fix log-log chart title.
walterra Aug 13, 2021
7a63579
[ML] Fetch up to 500 trace samples instead of just 10.
walterra Aug 13, 2021
843d96c
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 13, 2021
a928a2a
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 13, 2021
e5b2aae
[ML] Fix tests.
walterra Aug 13, 2021
77a3564
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 13, 2021
332c742
[ML] Fix assertion.
walterra Aug 13, 2021
f7b522c
[ML] Remove Array.from().
walterra Aug 16, 2021
154b386
[ML] Tweak var names related to percentiles.
walterra Aug 16, 2021
30ecfea
Merge branch 'master' into ml-apm-correlations-page
walterra Aug 16, 2021
ca6b687
[ML] Simplify code to find selectedSample
walterra Aug 16, 2021
3d80d2d
[ML] Fix waterfall message if no trace samples can be found. Fix clea…
walterra Aug 16, 2021
1284687
[ML] Refactor fetchers to reduce state handlers.
walterra Aug 17, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface SearchServiceParams {
start?: string;
end?: string;
percentileThreshold?: number;
sorenlouv marked this conversation as resolved.
Show resolved Hide resolved
percentileThresholdValue?: number;
analyzeCorrelations?: boolean;
}

export interface SearchServiceFetchParams extends SearchServiceParams {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,7 @@ type CorrelationsApiResponse = NonNullable<
APIReturnType<'GET /api/apm/correlations/errors/failed_transactions'>
>;

interface Props {
onClose: () => void;
}

export function ErrorCorrelations({ onClose }: Props) {
export function ErrorCorrelations() {
sorenlouv marked this conversation as resolved.
Show resolved Hide resolved
const [
selectedSignificantTerm,
setSelectedSignificantTerm,
Expand Down Expand Up @@ -130,7 +126,9 @@ export function ErrorCorrelations({ onClose }: Props) {
);

const trackApmEvent = useUiTracker({ app: 'apm' });
trackApmEvent({ metric: 'view_errors_correlations' });
trackApmEvent({ metric: 'view_failed_transactions' });

const onFilter = () => {};
sorenlouv marked this conversation as resolved.
Show resolved Hide resolved

return (
<>
Expand Down Expand Up @@ -175,7 +173,7 @@ export function ErrorCorrelations({ onClose }: Props) {
}
status={correlationsStatus}
setSelectedSignificantTerm={setSelectedSignificantTerm}
sorenlouv marked this conversation as resolved.
Show resolved Hide resolved
onFilter={onClose}
onFilter={onFilter}
/>
</EuiFlexItem>
<EuiFlexItem>
Expand Down
258 changes: 0 additions & 258 deletions x-pack/plugins/apm/public/components/app/correlations/index.tsx

This file was deleted.

Loading