Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Replace usages of EuiCodeEditor by CodeEditor #107434

Merged
merged 3 commits into from
Aug 5, 2021
Merged

[Fleet] Replace usages of EuiCodeEditor by CodeEditor #107434

merged 3 commits into from
Aug 5, 2021

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Aug 2, 2021 •
edited
Loading

Summary

Related to #106931
Resolve #107097

Replace usage of EuiCodeEditor by kbn CodeEditor

The component was used in the settings flyout and in the package policy editor for editing yaml

Notes:

  • I had to add Yaml support to the CodeEditor to have syntax highlighting
  • The CodeEditor component do not support a placeholder value I add to use an absolute positioned text to do that.

UI Changes

Before

Screen Shot 2021-08-02 at 1 44 30 PM

After

Screen Shot 2021-08-02 at 1 53 26 PM

Screen Shot 2021-08-02 at 1 43 13 PM

Screen Shot 2021-08-02 at 1 52 43 PM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 2, 2021
@nchaulet nchaulet requested review from a team as code owners August 2, 2021 17:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet self-assigned this Aug 2, 2021
@nchaulet nchaulet force-pushed the feature-107097-replace-usage-eui-code-editor branch from 92fbcca to 04c1c68 Compare August 2, 2021 18:01
@nchaulet nchaulet force-pushed the feature-107097-replace-usage-eui-code-editor branch from 04c1c68 to dad4cbe Compare August 2, 2021 18:18
@nchaulet
Copy link
Member Author

nchaulet commented Aug 3, 2021

@elasticmachine merge upstream

kpollich
kpollich approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nchaulet
Copy link
Member Author

nchaulet commented Aug 4, 2021

@elastic/kibana-presentation I had to register yaml language in the code editor to have syntax highlighting, let me know if it's the correct way to do it or if there is a better way.

@nchaulet
Copy link
Member Author

nchaulet commented Aug 5, 2021

@elasticmachine merge upstream

poffdeluxe
poffdeluxe approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review only)

@nchaulet nchaulet enabled auto-merge (squash) August 5, 2021 15:16
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 508 506 -2
kibanaReact 379 383 +4
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 723.7KB 716.8KB -6.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 146.7KB 150.3KB +3.6KB
Unknown metric groups

API count

id before after diff
kibanaReact 266 270 +4

API count missing comments

id before after diff
kibanaReact 236 240 +4

API count with any type

id before after diff
kibanaReact 6 8 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 3438a70 into elastic:master Aug 5, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 5, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 5, 2021
@nchaulet @kibanamachine
[Fleet] Replace usages of EuiCodeEditor by CodeEditor (elastic#107434)
323523d
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 5, 2021
@kibanamachine @nchaulet
[Fleet] Replace usages of EuiCodeEditor by CodeEditor (#107434) (#107778
d5967e8 
)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@nchaulet @vadimkibana
[Fleet] Replace usages of EuiCodeEditor by CodeEditor (elastic#107434)
1a981f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Replace usages of EuiCodeEditor
5 participants
@nchaulet @elasticmachine @kibanamachine @poffdeluxe @kpollich