Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test user with specific roles and permissions- for create index pattern wizard test #107984

Merged
merged 12 commits into from
Aug 12, 2021
Merged

test user with specific roles and permissions- for create index pattern wizard test #107984

merged 12 commits into from
Aug 12, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

part of Use test_user with minimum privileges for functional ui tests : #60815

@rashmivkulkarni rashmivkulkarni added v8.0.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Aug 10, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Aug 10, 2021
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review August 11, 2021 05:18
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni changed the title test user with specific roles and permissions test user with specific roles and permissions- for create index pattern wizard test Aug 11, 2021
@rashmivkulkarni rashmivkulkarni requested a review from LeeDr August 11, 2021 05:20
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

LeeDr
LeeDr suggested changes Aug 11, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused method in settings_page. I'm still checking on the privs on data streams

test/functional/page_objects/settings_page.ts Outdated Show resolved Hide resolved
test/functional/page_objects/settings_page.ts Show resolved Hide resolved
x-pack/test/functional/config.js Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

jportner
jportner approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM

LeeDr
LeeDr approved these changes Aug 12, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM - code review only

@rashmivkulkarni rashmivkulkarni added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 12, 2021
@rashmivkulkarni rashmivkulkarni merged commit 320fc8b into elastic:master Aug 12, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 12, 2021
@rashmivkulkarni @kibanamachine
test user with specific roles and permissions- for create index patte…
21d9bfe 
…rn wizard test (elastic#107984)

* test user with specific roles and permissions

* added SO method logging, added test data stream to the role and modified createindexpattern function

* removed unused method added in settings page

* removed unused index name- logs-*

* remove unused function from settings page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 12, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 12, 2021
@kibanamachine @rashmivkulkarni
test user with specific roles and permissions- for create index patte…
650e44a 
…rn wizard test (#107984) (#108413)

* test user with specific roles and permissions

* added SO method logging, added test data stream to the role and modified createindexpattern function

* removed unused method added in settings page

* removed unused index name- logs-*

* remove unused function from settings page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Rashmi Kulkarni <rashmi.kulkarni@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@jportner jportner jportner approved these changes

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashmivkulkarni @kibanamachine @jportner @LeeDr