Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Dashboard] [Embeddable] Add Ability to Defer Embeddable Loaded State (#107227) #108459

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

ThomThomson
Copy link
Contributor

Backports the following commits to 7.x:

…elastic#107227)

Added defer embeddable loading flag to embeddable for embeddables which aren't finished loading after their constructor is finished
@ThomThomson ThomThomson enabled auto-merge (squash) August 12, 2021 21:45
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 221.9KB 221.4KB -457.0B
lens 1.7MB 1.7MB +80.0B
maps 3.2MB 3.2MB +94.0B
total -283.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 159.4KB 159.8KB +449.0B
Unknown metric groups

API count

id before after diff
embeddable 460 467 +7
maps 213 214 +1
total +8

API count missing comments

id before after diff
embeddable 388 391 +3
maps 212 213 +1
total +4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 6c3580b into elastic:7.x Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants