Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import EuiCodeEditor from kibana #108846

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Import EuiCodeEditor from kibana #108846

merged 1 commit into from
Aug 17, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 17, 2021 •
edited
Loading

Summary

This PR actually imports the EUICodeEditor, used in vega and advanced settings, with the component that was moved to kibana #108318.

EUI wants to remove this component from their codebase #106931

In the future, we want to replace it with monaco editor.

@stratoula stratoula added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0 labels Aug 17, 2021
@stratoula stratoula marked this pull request as ready for review August 17, 2021 12:02
@stratoula stratoula requested a review from a team August 17, 2021 12:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested a review from timroes August 17, 2021 12:05
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 912.6KB 912.6KB +7.0B
visTypeVega 2.5MB 2.5MB +6.0B
total +13.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 9.0KB 9.3KB +237.0B
visTypeVega 55.2KB 55.4KB +237.0B
total +474.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

timroes
timroes approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome Linux. Both editors work as expected and fine to me. Code LGTM

@stratoula stratoula merged commit 0640a11 into elastic:master Aug 17, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Aug 17, 2021
@stratoula
Import EuiCodeEditor from kibana (elastic#108846)
3415059
@stratoula stratoula mentioned this pull request Aug 17, 2021
Merged
stratoula added a commit that referenced this pull request Aug 17, 2021
@stratoula
Import EuiCodeEditor from kibana (#108846) (#108916)
3958013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stratoula @elasticmachine @kibanamachine @timroes