-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix UI inconsistencies in APM Failed transaction correlations #109187
Merged
Merged
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8dade28
[ML] Fix UI inconsistencies, add sorting
qn895 eb5ba19
[ML] Fix columns for latency sortable
qn895 420e183
[ML] Fix columns for latency sortable
qn895 6f9ffa1
[ML] Rename log -> correlations_log.tsx, update help texts
qn895 bdd7143
[ML] Remove event.outcome as candidate for failed transaction correla…
qn895 4a5be20
[ML] Shrink the score column
qn895 cf9284c
[ML] Add colored badge for high, medium, low thresholds
qn895 be26575
[ML] Comment on hard coded height
qn895 84a0514
[ML] Sort by normalized
qn895 3e34c5a
[ML] Fix latency encoding
qn895 1d0a6f5
[ML] Add functional tests
qn895 8300462
[ML] Update jest tests
qn895 1497d3d
[ML] Fix license text, test subj
qn895 85caf98
[ML] Remove unused color constant
qn895 8e52377
Merge remote-tracking branch 'upstream/master' into ml-fix-apm-transa…
qn895 82d5457
[ML] Update correlations_log, add more tests for asAbsoluteDateTime, …
qn895 4ab3871
[ML] Only show the p-value hover on inspect mode
qn895 0b66643
[ML] Add new error rate columns
qn895 5999243
Merge remote-tracking branch 'upstream/master' into ml-fix-apm-transa…
qn895 6403616
[ML] Add new error rate columns
qn895 e683e57
[ML] Add api integration test for failed transaction ss
qn895 7d52366
[ML] Fix api tests
qn895 e4c0d3a
Merge remote-tracking branch 'upstream/master' into ml-fix-apm-transa…
qn895 909e203
fix api test names
walterra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
x-pack/plugins/apm/public/components/app/correlations/cross_cluster_search_warning.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { EuiCallOut } from '@elastic/eui'; | ||
import React from 'react'; | ||
import { i18n } from '@kbn/i18n'; | ||
|
||
export function CrossClusterSearchCompatibilityWarning({ | ||
version, | ||
}: { | ||
version: string; | ||
}) { | ||
return ( | ||
<EuiCallOut | ||
title={i18n.translate('xpack.apm.correlations.ccsWarningCalloutTitle', { | ||
defaultMessage: 'Cross-cluster search compatibility', | ||
})} | ||
color="warning" | ||
> | ||
<p> | ||
{i18n.translate('xpack.apm.correlations.ccsWarningCalloutBody', { | ||
defaultMessage: | ||
'Data for the correlation analysis could not be fully retrieved. This feature is supported only for {version} and later versions.', | ||
values: { version }, | ||
})} | ||
</p> | ||
</EuiCallOut> | ||
); | ||
} |
48 changes: 48 additions & 0 deletions
48
x-pack/plugins/apm/public/components/app/correlations/empty_state_prompt.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { EuiEmptyPrompt, EuiSpacer, EuiText } from '@elastic/eui'; | ||
import React from 'react'; | ||
import { i18n } from '@kbn/i18n'; | ||
import { FormattedMessage } from '@kbn/i18n/react'; | ||
|
||
export function CorrelationsEmptyStatePrompt() { | ||
return ( | ||
<> | ||
<EuiSpacer size="m" /> | ||
<EuiEmptyPrompt | ||
iconType="minusInCircle" | ||
title={ | ||
<EuiText size="s"> | ||
<h2> | ||
{i18n.translate('xpack.apm.correlations.noCorrelationsTitle', { | ||
defaultMessage: 'No significant correlations', | ||
})} | ||
</h2> | ||
</EuiText> | ||
} | ||
body={ | ||
<> | ||
<EuiText size="s"> | ||
<FormattedMessage | ||
id="xpack.apm.correlations.noCorrelationsTextLine1" | ||
defaultMessage="Correlations will only be identified if they have significant impact." | ||
/> | ||
</EuiText> | ||
{/* Another EuiText element to enforce a line break */} | ||
<EuiText size="s"> | ||
<FormattedMessage | ||
id="xpack.apm.correlations.noCorrelationsTextLine2" | ||
defaultMessage="Try selecting another time range or remove any added filter." | ||
/> | ||
</EuiText> | ||
</> | ||
} | ||
/> | ||
</> | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like you want two paragraphs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here 82d5457