Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler #109432

Merged
merged 6 commits into from
Aug 23, 2021
Merged

chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler #109432

merged 6 commits into from
Aug 23, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 20, 2021

One step forward on #69706

That PR moves the @kbn/securitysolution-hook-utils from using tsc compiler to babel transpiler to produce the js outputs.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v7.14.1 labels Aug 20, 2021
@mistic mistic requested a review from jbudz August 20, 2021 12:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from FrankHassanabad August 20, 2021 12:13
@mistic
Copy link
Member Author

mistic commented Aug 20, 2021

@elasticmachine merge upstream

@mistic @FrankHassanabad
chore(NA): update packages/kbn-securitysolution-hook-utils/.babelrc
2a3b4bb 
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
FrankHassanabad
FrankHassanabad approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • Looked over this PR and compared it to similar ones and the directory structures to see if anything was overlooked

@mistic
Copy link
Member Author

mistic commented Aug 22, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 287.7KB 288.6KB +930.0B
securitySolution 6.5MB 6.5MB +1.0KB
total +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 9a7ebb7 into elastic:master Aug 23, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@mistic @kibanamachine @FrankHassanabad
chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler (
9365502 
elastic#109432)

* chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler

* chore(NA): update packages/kbn-securitysolution-hook-utils/.babelrc

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

* chore(NA): correct deps

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@mistic @kibanamachine @FrankHassanabad
chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler (
c4e9caf 
elastic#109432)

* chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler

* chore(NA): update packages/kbn-securitysolution-hook-utils/.babelrc

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

* chore(NA): correct deps

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 7.15
✅ 7.x
❌ 7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 109432

mistic added a commit to mistic/kibana that referenced this pull request Aug 23, 2021
@mistic
chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler (
7342524 
elastic#109432)

* chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler

* chore(NA): update packages/kbn-securitysolution-hook-utils/.babelrc

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

* chore(NA): correct deps

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
# Conflicts:
#	packages/kbn-securitysolution-hook-utils/BUILD.bazel
#	packages/kbn-securitysolution-hook-utils/tsconfig.json
@mistic mistic mentioned this pull request Aug 23, 2021
Merged
mistic added a commit that referenced this pull request Aug 23, 2021
@mistic
chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler (
91e17d9 
#109432) (#109667)

* chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler

* chore(NA): update packages/kbn-securitysolution-hook-utils/.babelrc

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

* chore(NA): correct deps

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
# Conflicts:
#	packages/kbn-securitysolution-hook-utils/BUILD.bazel
#	packages/kbn-securitysolution-hook-utils/tsconfig.json
kibanamachine added a commit that referenced this pull request Aug 23, 2021
@kibanamachine @mistic @FrankHassanabad
chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler (
48aa983 
#109432) (#109666)

* chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler

* chore(NA): update packages/kbn-securitysolution-hook-utils/.babelrc

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

* chore(NA): correct deps

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
kibanamachine added a commit that referenced this pull request Aug 23, 2021
@kibanamachine @mistic @FrankHassanabad
chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler (
24386d9 
#109432) (#109665)

* chore(NA): moving @kbn/securitysolution-hook-utils to babel transpiler

* chore(NA): update packages/kbn-securitysolution-hook-utils/.babelrc

Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

* chore(NA): correct deps

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Frank Hassanabad <frankhassanabad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.1 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibanamachine @FrankHassanabad @jbudz