-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds Lens Inspector and minor edits #109736
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seems ok to me, but the referenced issue looks different in content than the changes in this PR. Maybe you meant to reference some other PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beyond my 1 comment everything else looks good! approving so you aren't blocked
docs/user/dashboard/lens.asciidoc
Outdated
+ | ||
``` | ||
count(kql='response.status_code > 400') / count() | ||
``` | ||
+ | ||
Week over week example:: Use `shift='1w'` to get the value of each grouping from the previous week. Time shift should not be used with the *Top values* function. | ||
Week over week example:: To get the value for each grouping from the previous week, use `shift='1w'`. Do not use time shift formulas with the *Top values* function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use time shift formulas with the Top values function.
It's unfortunately not that simple. You can do top values & a shift at the same time....but if your formula contains both a shift & no shift, for example then the top values function won't work.
I'll be sitting here for the next few minutes trying to think of a simple way to say that 😖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about: If your formula contains a time shift and a non-shifted metric then you cannot currently use Top Values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current error message says it better, as the problem is with multiple different time shift
rather than time shift vs non-time shift:
It is not possible to combine different time shifts with the Top values function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think specifying the different time shifts instead of saying different
is clearer. On the other hand, using different
is a simpler way of stating this, especially when I finally understood the different time shifts "types".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dej611 is better at english than I am. my parents would be so proud 😂
nice one, sounds much better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think specifying the different time shifts instead of saying
different
is clearer. On the other hand, usingdifferent
is a simpler way of stating this, especially when I finally understood the different time shifts "types".
I thought about different formulations, but the main point, at the end, is not mixing them:
count(shift="1w") - count() // "different": in this case is 1w vs 0 shift
count(shift="1w") - count(shift="1m") // "different": in this case is 1w vs 1m
Of course when Top values
is selected as function on other dimensions.
We might think to include this type of example as well to better explain, but it's probably too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! Double check my work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few minor comments.
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* [DOCS] Adds Lens Inspector and minor edits * Update docs/user/dashboard/lens.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Removes outdated menus and adds new visual component content * Updates with review comments * Last review comment Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* [DOCS] Adds Lens Inspector and minor edits * Update docs/user/dashboard/lens.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Removes outdated menus and adds new visual component content * Updates with review comments * Last review comment Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* [DOCS] Adds Lens Inspector and minor edits * Update docs/user/dashboard/lens.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Removes outdated menus and adds new visual component content * Updates with review comments * Last review comment Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* [DOCS] Adds Lens Inspector and minor edits * Update docs/user/dashboard/lens.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Removes outdated menus and adds new visual component content * Updates with review comments * Last review comment Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (65 commits) Move to vis_types folder part 2 (elastic#110574) [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023) [Discover] Remove export* syntax (elastic#110934) [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365) [Security Solution][Detection Rules] Changes 'activated' text on rule details page (elastic#111044) [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300) [package testing] Update logging and pid configuration (elastic#111059) [Dashboard] Read App State from URL on Soft Refresh (elastic#109354) Add correct roles to test user for functional tests in dashboard (elastic#110880) [DOCS] Adds Lens Inspector and minor edits (elastic#109736) [DOCS] Updates Spaces page (elastic#111005) normalize initialNamespaces (elastic#110936) [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740) [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253) skip flaky suites: elastic#111001, elastic#111022 [Security Solution][RAC] - Update reason field text (elastic#110308) [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913) [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971) [DOCS] Updates Discover docs (elastic#110346) [RAC] Persistent timeline fields fix (elastic#110685) ...
Summary