Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds Lens Inspector and minor edits #109736

Merged
merged 5 commits into from
Sep 2, 2021

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Aug 23, 2021

Summary

  • Updates the Lens page with minor edits
  • Removes outdated menu options, and adds list of menus available from the editor toolbar
  • Simplifies Download panel data with only one option instead of additional Lens option

@KOTungseth KOTungseth added Team:Docs Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.15.0 v7.16.0 labels Aug 23, 2021
@KOTungseth KOTungseth requested a review from dej611 August 23, 2021 20:13
@KOTungseth KOTungseth self-assigned this Aug 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@KOTungseth KOTungseth requested review from gchaps and ghudgins August 23, 2021 20:13
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seems ok to me, but the referenced issue looks different in content than the changes in this PR. Maybe you meant to reference some other PR?

Copy link
Contributor

@ghudgins ghudgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beyond my 1 comment everything else looks good! approving so you aren't blocked

+
```
count(kql='response.status_code > 400') / count()
```
+
Week over week example:: Use `shift='1w'` to get the value of each grouping from the previous week. Time shift should not be used with the *Top values* function.
Week over week example:: To get the value for each grouping from the previous week, use `shift='1w'`. Do not use time shift formulas with the *Top values* function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use time shift formulas with the Top values function.

It's unfortunately not that simple. You can do top values & a shift at the same time....but if your formula contains both a shift & no shift, for example then the top values function won't work.

I'll be sitting here for the next few minutes trying to think of a simple way to say that 😖

Copy link
Contributor

@ghudgins ghudgins Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: If your formula contains a time shift and a non-shifted metric then you cannot currently use Top Values.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current error message says it better, as the problem is with multiple different time shift rather than time shift vs non-time shift:

It is not possible to combine different time shifts with the Top values function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think specifying the different time shifts instead of saying different is clearer. On the other hand, using different is a simpler way of stating this, especially when I finally understood the different time shifts "types".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dej611 is better at english than I am. my parents would be so proud 😂

nice one, sounds much better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think specifying the different time shifts instead of saying different is clearer. On the other hand, using different is a simpler way of stating this, especially when I finally understood the different time shifts "types".

I thought about different formulations, but the main point, at the end, is not mixing them:

count(shift="1w") - count() // "different": in this case is 1w vs 0 shift
count(shift="1w") - count(shift="1m") // "different": in this case is 1w vs 1m

Of course when Top values is selected as function on other dimensions.
We might think to include this type of example as well to better explain, but it's probably too much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! Double check my work?

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments.

docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
@KOTungseth KOTungseth merged commit d920105 into elastic:master Sep 2, 2021
@KOTungseth KOTungseth deleted the docs/7.15-lens branch September 2, 2021 20:49
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Sep 2, 2021
* [DOCS] Adds Lens Inspector and minor edits

* Update docs/user/dashboard/lens.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Removes outdated menus and adds new visual component content

* Updates with review comments

* Last review comment

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Sep 2, 2021
* [DOCS] Adds Lens Inspector and minor edits

* Update docs/user/dashboard/lens.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Removes outdated menus and adds new visual component content

* Updates with review comments

* Last review comment

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
KOTungseth added a commit that referenced this pull request Sep 2, 2021
* [DOCS] Adds Lens Inspector and minor edits

* Update docs/user/dashboard/lens.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Removes outdated menus and adds new visual component content

* Updates with review comments

* Last review comment

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
KOTungseth added a commit that referenced this pull request Sep 2, 2021
* [DOCS] Adds Lens Inspector and minor edits

* Update docs/user/dashboard/lens.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Removes outdated menus and adds new visual component content

* Updates with review comments

* Last review comment

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2021
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (65 commits)
  Move to vis_types folder part 2 (elastic#110574)
  [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023)
  [Discover] Remove export* syntax (elastic#110934)
  [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365)
  [Security Solution][Detection Rules] Changes 'activated' text on rule details page  (elastic#111044)
  [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300)
  [package testing] Update logging and pid configuration (elastic#111059)
  [Dashboard] Read App State from URL on Soft Refresh (elastic#109354)
  Add correct roles to test user for functional tests in dashboard (elastic#110880)
  [DOCS] Adds Lens Inspector and minor edits (elastic#109736)
  [DOCS] Updates Spaces page (elastic#111005)
  normalize initialNamespaces (elastic#110936)
  [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740)
  [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253)
  skip flaky suites: elastic#111001, elastic#111022
  [Security Solution][RAC] - Update reason field text (elastic#110308)
  [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913)
  [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971)
  [DOCS] Updates Discover docs (elastic#110346)
  [RAC] Persistent timeline fields fix (elastic#110685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants