Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert default to named exports: ui/public/agg_response/* #10987

Merged

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Mar 31, 2017

Related to #10981, chunk of work for agg_response.

Background: #8641

@stacey-gammon stacey-gammon force-pushed the default-to-named-agg-response branch from 6dcdbd8 to 8079b4e Compare April 3, 2017 13:03
@stacey-gammon stacey-gammon changed the title Convert default to named exports starting with agg_response code Convert default to named exports: ui/public/agg_response/* Apr 3, 2017
@stacey-gammon stacey-gammon force-pushed the default-to-named-agg-response branch 3 times, most recently from a6af2d9 to a715906 Compare April 3, 2017 16:07
@stacey-gammon stacey-gammon requested a review from ppisljar April 3, 2017 20:59
@stacey-gammon stacey-gammon force-pushed the default-to-named-agg-response branch from a715906 to f3cb46e Compare April 4, 2017 18:38
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stacey-gammon stacey-gammon force-pushed the default-to-named-agg-response branch from 29797a0 to f4d3c3b Compare April 11, 2017 15:58
@stacey-gammon stacey-gammon merged commit bf63cac into elastic:master Apr 12, 2017
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Apr 12, 2017
…0987)

* Convert default to named exports starting with agg_response code

* Default to Named: Agg Response - Chunk 2

Committing in chunks so I can check test passes

* Default to Named: Agg Response - Chunk 3

* Default to Named: Agg Response - Chunk 4

* Default to named: AggTypes - Chunk 1
stacey-gammon added a commit that referenced this pull request Apr 13, 2017
) (#11194)

* Convert default to named exports: ui/public/agg_response/* (#10987)

* Convert default to named exports starting with agg_response code

* Default to Named: Agg Response - Chunk 2

Committing in chunks so I can check test passes

* Default to Named: Agg Response - Chunk 3

* Default to Named: Agg Response - Chunk 4

* Default to named: AggTypes - Chunk 1

* Convert references not included in master

* More conversions
@stacey-gammon stacey-gammon deleted the default-to-named-agg-response branch October 24, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants