Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] remove map.regionmap.* #109896

Merged
merged 6 commits into from
Aug 30, 2021
Merged

[Maps] remove map.regionmap.* #109896

merged 6 commits into from
Aug 30, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 24, 2021 •
edited
Loading

Fixes #81704

Remove map.regionmap.* kibana.yml settings. Functionality has been replaced with GeoJSON upload and is no longer needed. Doing this to simplifying user interface and reduce maintenance.

@nreese nreese added release_note:breaking [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 labels Aug 24, 2021
@nreese nreese marked this pull request as ready for review August 24, 2021 20:17
@nreese nreese requested review from a team as code owners August 24, 2021 20:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from thomasneirynck August 24, 2021 20:17
mshustov
mshustov approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the core changes

@nreese
Copy link
Contributor Author

nreese commented Aug 30, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 850 846 -4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
mapsEms 75 74 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.1MB 3.1MB -3.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 78.4KB 78.1KB -270.0B
Unknown metric groups

API count

id before after diff
mapsEms 75 74 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@nreese nreese added the backport:skip This commit does not require backporting label Aug 30, 2021
@nreese nreese merged commit 9e1a4dd into elastic:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:breaking v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Breaking change] Remove map.regionmap.* kibana.yml settings
5 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck @mshustov