Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled #110053

Merged
merged 4 commits into from
Aug 27, 2021
Merged

[ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled #110053

merged 4 commits into from
Aug 27, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Aug 25, 2021 •
edited by peteharverson
Loading

Summary

Part of #97269.

Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.

Before:

image

After:

image

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience release_note:fix :ml v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.15.0 v7.16.0 labels Aug 25, 2021
@walterra walterra self-assigned this Aug 25, 2021
@walterra walterra requested review from a team as code owners August 25, 2021 13:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@walterra walterra removed the request for review from a team August 25, 2021 13:24
@walterra walterra removed the Team:APM All issues that need APM UI Team support label Aug 25, 2021
@walterra
Copy link
Contributor Author

Sorry, unintended ping of the APM team, removed related code and labels.

peteharverson
peteharverson approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Leaving #97269 open as eventually it would be good to get the full interaction for the header cells as you have when the histograms are not enabled:

image

alvarezmelissa87
alvarezmelissa87 approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

cchaos
cchaos reviewed Aug 26, 2021
View reviewed changes
x-pack/plugins/ml/public/application/components/data_grid/data_grid.scss
Comment on lines +6 to +7
// Override to align the sorting arrow at the bottom when histogram charts are enabled
.euiDataGridHeaderCell .euiDataGridHeaderCell__sortingArrow {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a request in EUI to allow passing a custom class name to the EuiDataGridHeaderCell?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an issue in EUI here: elastic/eui#5106
We'd like to get this in 7.15 do you think there will be another EUI fix release that could include this or are you fine with merging this and we keep track of an EUI update to resolve this later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not considered something we'd usually backport for. Do what you need to do.

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@walterra walterra mentioned this pull request Aug 27, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +416.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 27, 2021
@walterra walterra merged commit 8eea900 into elastic:master Aug 27, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 27, 2021
@walterra @kibanamachine
[ML] Data Grid: Fix alignment of sorting arrow when histogram charts …
d66dad7 
…are enabled (elastic#110053)

Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.
@kibanamachine kibanamachine mentioned this pull request Aug 27, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 27, 2021
@walterra @kibanamachine
[ML] Data Grid: Fix alignment of sorting arrow when histogram charts …
47960e8 
…are enabled (elastic#110053)

Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.
@kibanamachine kibanamachine mentioned this pull request Aug 27, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

@walterra walterra deleted the ml-data-grid-fix-sorting-icon-position branch August 27, 2021 21:56
kibanamachine added a commit that referenced this pull request Aug 28, 2021
@kibanamachine @walterra
[ML] Data Grid: Fix alignment of sorting arrow when histogram charts …
e23cc5f 
…are enabled (#110053) (#110415)

Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 28, 2021
@kibanamachine @walterra
[ML] Data Grid: Fix alignment of sorting arrow when histogram charts …
0e22329 
…are enabled (#110053) (#110416)

Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into vis/migrate-r…
fcc34f0 
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (120 commits)
  [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218)
  skip flaky suite (elastic#98463)
  skip flaky suite (elastic#108633)
  [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903)
  fixes failing tests (elastic#110436)
  [TSVB] Remove deprecated `IFieldType` (elastic#110404)
  [Lens] Remove deprecated `IFieldType` (elastic#109825)
  [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023)
  [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031)
  [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914)
  Don't add split part of UI if we have one series (elastic#109483)
  [Discover] Migrate angular routing to react router (elastic#107042)
  [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282)
  [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053)
  [canvas] Fix image argument form issues (elastic#109767)
  Fix asset in Pitch template (elastic#109742)
  chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265)
  chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269)
  [Fleet] Fix upgrade link in Fleet policy table (elastic#110228)
  [ML] APM Latency Correlations: Fix empty state (elastic#109813)
  ...

# Conflicts:
#	src/plugins/data/common/query/timefilter/types.ts
@peteharverson peteharverson mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@walterra walterra

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibanamachine @cchaos @alvarezmelissa87 @peteharverson