Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/securitysolution-io-ts-utils to babel transpiler #110099

Merged
merged 4 commits into from
Aug 26, 2021
Merged

chore(NA): moving @kbn/securitysolution-io-ts-utils to babel transpiler #110099

merged 4 commits into from
Aug 26, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 25, 2021

One step forward on #69706

That PR moves the @kbn/securitysolution-io-ts-utils from using tsc compiler to babel transpiler to produce the js outputs.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v7.14.1 labels Aug 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic added v7.14.2 and removed v7.14.1 labels Aug 25, 2021
@mistic
Copy link
Member Author

mistic commented Aug 25, 2021

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Aug 26, 2021

@elasticmachine merge upstream

FrankHassanabad
FrankHassanabad approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • Looked it over and its like all the rest

Btw, LOVE THESE PR's and how all of this is coming together! Thank you!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 247 248 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 295.7KB 297.0KB +1.3KB
securitySolution 6.5MB 6.5MB +747.0B
total +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit bf6e124 into elastic:master Aug 26, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 26, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/securitysolution-io-ts-utils to babel transpil…
97bb8a6 
…er (elastic#110099)

* chore(NA): moving @kbn/securitysolution-io-ts-utils to babel transpiler

* chore(NA): introduce browser targets

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 26, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 26, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/securitysolution-io-ts-utils to babel transpil…
99ac48b 
…er (#110099) (#110301)

* chore(NA): moving @kbn/securitysolution-io-ts-utils to babel transpiler

* chore(NA): introduce browser targets

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibanamachine @FrankHassanabad @jbudz