Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Job import and export functional tests #110578

Merged
merged 13 commits into from
Sep 3, 2021
Merged

[ML] Job import and export functional tests #110578

merged 13 commits into from
Sep 3, 2021

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 31, 2021 •
edited
Loading

Adds tests to import a files containing anomaly detection and data frame analytics jobs.

Tests that files are read correctly, listing the expected job ids and the job type.
Tests that the jobs are imported correctly and exist in the jobs lists.

Also tests a file which contains bad data.

Adds tests to export anomaly detection and data frame analytics jobs to file and then compares these exported jobs to the originally created jobs.

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic changed the title [ML] Job import export functional tests [ML] Job import functional tests Sep 1, 2021
@jgowdyelastic jgowdyelastic self-assigned this Sep 1, 2021
@jgowdyelastic jgowdyelastic added :ml Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review test v7.16.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Sep 1, 2021
@jgowdyelastic jgowdyelastic marked this pull request as ready for review September 1, 2021 12:47
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 1, 2021 12:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member

pheyos commented Sep 1, 2021 •
edited
Loading

Checking test stability in a flaky test runner job ... no ML failure in 50 runs (just one unrelated licensing plugin failure) ✔️

pheyos
pheyos reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these tests coming! 🎉
Left a few comments.

x-pack/test/functional/services/ml/stack_management_jobs.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/stack_management_jobs.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/stack_management_jobs.ts Outdated Show resolved Hide resolved
@jgowdyelastic jgowdyelastic changed the title [ML] Job import functional tests [ML] Job import and export functional tests Sep 2, 2021
@peteharverson peteharverson mentioned this pull request Sep 2, 2021
Closed
14 tasks
@pheyos
Copy link
Member

pheyos commented Sep 2, 2021 •
edited
Loading

Checking test stability for the added export tests in another flaky test runner job ... no failure in 50 runs ✔️

pheyos
pheyos reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that the export jobs tests have joined this PR 😁
Left a few comments / questions.

...l/public/application/components/import_export_jobs/export_jobs_flyout/export_jobs_flyout.tsx Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/stack_management_jobs.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/stack_management_jobs.ts Show resolved Hide resolved
x-pack/test/functional/services/ml/stack_management_jobs.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/stack_management_jobs.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/stack_management_jobs.ts Show resolved Hide resolved
pheyos
pheyos approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

peteharverson
peteharverson approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo in an existing callout, but otherwise LGTM.

...ic/application/components/import_export_jobs/import_jobs_flyout/cannot_read_file_callout.tsx
<div data-test-subj="mlJobMgmtImportJobsFileReadErrorCallout">
<FormattedMessage
id="xpack.ml.importExport.importFlyout.cannotReadFileCallout.body"
defaultMessage="Please select a file contained Machine Learning jobs which have been exported from Kibana using the Export Jobs option"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but noticed a typo in this message - should be containing not contained.

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 71571c5 into elastic:master Sep 3, 2021
@jgowdyelastic jgowdyelastic deleted the job-import-export-functional-tests branch September 3, 2021 13:05
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 3, 2021
@jgowdyelastic @kibanamachine
[ML] Job import and export functional tests (elastic#110578)
3740540 
* [ML] Job import export functional tests

* adding title check

* adding dfa tests

* removing export file

* adds bad data test

* commented code

* adding export job tests

* adds version to file names

* improving tests

* removing comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 3, 2021
@kibanamachine @jgowdyelastic
[ML] Job import and export functional tests (#110578) (#111128)
0b69a11 
* [ML] Job import export functional tests

* adding title check

* adding dfa tests

* removing export file

* adds bad data test

* commented code

* adding export job tests

* adds version to file names

* improving tests

* removing comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review test_ui_functional test v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @pheyos @kibanamachine @peteharverson