-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Deprecate apm_oss.indexPattern
config option
#111133
[APM] Deprecate apm_oss.indexPattern
config option
#111133
Conversation
const deprecations: ConfigDeprecationProvider = ({ unused }) => [ | ||
unused('fleetMode'), | ||
unused('indexPattern'), | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is how the option should be deprecated.
Pinging @elastic/apm-ui (Team:apm) |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/get·ts.alerting api integration security and spaces enabled Alerts alerts get "after each" hook for "shouldn't get alert from another space"Standard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
Closes #110733
This PR removes the need for
apm_oss.indexPattern
by constructing it by concatenating the specified indicies.This test illustrates it pretty well:
https://github.com/elastic/kibana/blob/47c10042787238661527e46a6cf9dde684b61cd6/x-pack/plugins/apm/server/lib/index_pattern/get_apm_index_pattern_title.test.ts
Having
apm_oss.indexPattern
was problematic because it forced end users to keep this value in sync with their specified indicies. A user wanted to enable CCS and updated their index settings via the ui but forgot to updateapm_oss.indexPattern
which caused the search bar and Discover to not work as expected. Without a hardcoded value this won't happen.