Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOM] Improve warning when trying to delete hidden objects #111698

Merged
merged 5 commits into from
Sep 10, 2021
Merged

[SOM] Improve warning when trying to delete hidden objects #111698

merged 5 commits into from
Sep 10, 2021

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Sep 9, 2021 •
edited
Loading

Summary

Fix #106581

Improve the warning message of the delete confirmation modal when trying to delete hidden objects.

before:

Screenshot 2021-09-09 at 11 24 41

after:

Screenshot 2021-09-09 at 11 37 04

Checklist

@pgayvallet pgayvallet added Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects Management and removed Feature:Saved Objects labels Sep 9, 2021
@pgayvallet pgayvallet marked this pull request as ready for review September 9, 2021 12:02
@pgayvallet pgayvallet requested a review from a team as a code owner September 9, 2021 12:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Sep 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
savedObjectsManagement 131.0KB 131.1KB +179.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only and the changes LGTM.
We might want to add a bit of info around what a hidden saved object is later on, if we think that folks might not know what makes a SO hidden and get confused about not being able to delete those.

@pgayvallet pgayvallet added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 10, 2021
@pgayvallet pgayvallet merged commit c78121c into elastic:master Sep 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 10, 2021
@pgayvallet @kibanamachine
[SOM] Improve warning when trying to delete hidden objects (elastic#1…
eb2bc5f 
…11698)

* improve warning message when trying to delete hidden saved objects

* improve message

* fix pluralize

* fix title
@kibanamachine kibanamachine mentioned this pull request Sep 10, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 10, 2021
@kibanamachine @pgayvallet
[SOM] Improve warning when trying to delete hidden objects (#111698) (#…
57a9bbd 
…111835)

* improve warning message when trying to delete hidden saved objects

* improve message

* fix pluralize

* fix title

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Saved Objects Management release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better UX if user tries to delete hidden saved objects
4 participants
@pgayvallet @elasticmachine @kibanamachine @TinaHeiligers