Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Remove grunt (#111882) #112474

Merged
merged 1 commit into from
Sep 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions Gruntfile.js

This file was deleted.

6 changes: 0 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"**/hoist-non-react-statics": "^3.3.2",
"**/isomorphic-fetch/node-fetch": "^2.6.1",
"**/istanbul-instrumenter-loader/schema-utils": "1.0.0",
"**/load-grunt-config/lodash": "^4.17.21",
"**/minimist": "^1.2.5",
"**/node-jose/node-forge": "^0.10.0",
"**/pdfkit/crypto-js": "4.0.0",
Expand Down Expand Up @@ -311,7 +310,6 @@
"papaparse": "^5.2.0",
"pdfmake": "^0.1.65",
"peggy": "^1.2.0",
"pegjs": "0.10.0",
"pluralize": "3.1.0",
"pngjs": "^3.4.0",
"polished": "^3.7.2",
Expand Down Expand Up @@ -722,9 +720,6 @@
"form-data": "^4.0.0",
"geckodriver": "^2.0.4",
"glob-watcher": "5.0.3",
"grunt": "1.3.0",
"grunt-available-tasks": "^0.6.3",
"grunt-peg": "^2.0.1",
"gulp": "4.0.2",
"gulp-babel": "^8.0.0",
"gulp-brotli": "^3.0.0",
Expand Down Expand Up @@ -762,7 +757,6 @@
"license-checker": "^16.0.0",
"listr": "^0.14.1",
"lmdb-store": "^1.6.6",
"load-grunt-config": "^3.0.1",
"marge": "^1.0.1",
"micromatch": "3.1.10",
"minimist": "^1.2.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ A package should follow the pattern of having `.test.js` files as siblings of th

A package using the `.test.js` naming convention will have those tests automatically picked up by Jest and run by the unit test runner, currently mapped to the Kibana `test` script in the root `package.json`.

* `yarn test` or `yarn grunt test` runs all unit tests.
* `yarn test` runs all unit tests.
* `yarn jest` runs all Jest tests in Kibana.

In order for the plugin or package to use Jest, a jest.config.js file must be present in it's root. However, there are safeguards for this in CI should a test file be added without a corresponding config file.
Expand Down
2 changes: 1 addition & 1 deletion src/dev/build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ NODE_OPTIONS="--max-old-space-size=4096" node scripts/build --release

# Structure

The majority of this logic is extracted from the grunt build that has existed forever, and is designed to maintain the general structure grunt provides including tasks and config. The [build_distributables.js] file defines which tasks are run.
The majority of this logic is extracted from the legacy grunt build, and is designed to maintain the general structure grunt provides including tasks and config. The [build_distributables.js] file defines which tasks are run.

**Task**: [tasks/\*] define individual parts of the build. Each task is an object with a `run()` method, a `description` property, and optionally a `global` property. They are executed with the runner either once (if they are global) or once for each build. Non-global/local tasks are called once for each build, meaning they will be called twice be default, once for the OSS build and once for the default build and receive a build object as the third argument to `run()` which can be used to determine paths and properties for that build.

Expand Down
2 changes: 0 additions & 2 deletions src/dev/precommit_hook/casing_check_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ export const IGNORE_FILE_GLOBS = [
'**/+([A-Z_]).asciidoc',
'**/LICENSE',
'**/*.txt',
'**/Gruntfile.js',
'tasks/config/**/*',
'**/{Dockerfile,docker-compose.yml}',
'x-pack/plugins/canvas/tasks/**/*',
'x-pack/plugins/canvas/canvas_plugin_src/**/*',
Expand Down
1 change: 0 additions & 1 deletion src/dev/precommit_hook/check_file_casing.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ async function checkForKebabCase(log, files) {
* Check that all passed File objects are using valid casing. Every
* file SHOULD be using snake_case but some files are allowed to stray:
*
* - grunt config: the file name needs to match the module name
* - eslint/babel packages: the directory name matches the module
* name, which uses kebab-case to mimic other babel/eslint plugins,
* configs, and presets
Expand Down
24 changes: 0 additions & 24 deletions tasks/config/availabletasks.js

This file was deleted.

9 changes: 0 additions & 9 deletions tasks/config/peg.js

This file was deleted.

Loading