Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Prevent our plugins from being disabled #113461

Merged
merged 10 commits into from
Oct 5, 2021
Merged

[Alerting] Prevent our plugins from being disabled #113461

merged 10 commits into from
Oct 5, 2021

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Sep 29, 2021 •
edited
Loading

Resolves #90934

This PR will not be backported and once it's in master, our plugins cannot be disabled!

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@chrisronline chrisronline marked this pull request as ready for review September 29, 2021 20:35
@chrisronline chrisronline requested a review from a team as a code owner September 29, 2021 20:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many code was removed! LGTM

@lukeelmers
Copy link
Member

lukeelmers commented Sep 30, 2021 •
edited
Loading

Make sure you also remove these settings from src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker (I'm currently working on the PR for removing these settings from the rest of the plugins, and noticed the actions & TM settings were still in this file)

Edit: Despite the comment in the header, the above file is not actually auto-generated... it confusingly is included as part of the source for a file that's autogenerated

ymao1
ymao1 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisronline chrisronline force-pushed the alerting/cannot_disable branch from 53afe10 to 7e031cd Compare September 30, 2021 13:26
@chrisronline chrisronline requested a review from a team as a code owner September 30, 2021 13:26
@chrisronline
Copy link
Contributor Author

@ymao1 @YulNaumenko Thanks for the review! I forgot to include the event_log plugin so I pinged you both to re-review based on a good set of changes in d63a4ec

ymao1
ymao1 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the latest commit and still LGTM!

@chrisronline chrisronline force-pushed the alerting/cannot_disable branch from 9cde508 to 1c505f0 Compare September 30, 2021 16:35
@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@gmmorris
Copy link
Contributor

gmmorris commented Oct 4, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventLog 81 80 -1
Unknown metric groups

API count

id before after diff
eventLog 81 80 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 3f4240b into elastic:master Oct 5, 2021
@chrisronline chrisronline added the backport:skip This commit does not require backporting label Oct 5, 2021
@chrisronline chrisronline deleted the alerting/cannot_disable branch October 5, 2021 19:30
@ymao1 ymao1 mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@jbudz jbudz jbudz approved these changes

@YulNaumenko YulNaumenko Awaiting requested review from YulNaumenko

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Actions Feature:Alerting Feature:Task Manager release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[8.0 only] Should the alerting services plugin always be enabled?
8 participants
@chrisronline @elasticmachine @lukeelmers @gmmorris @kibanamachine @jbudz @ymao1 @YulNaumenko