Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotates beats tutorials with custom integration categories #113565

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Annotates beats tutorials with custom integration categories #113565

merged 2 commits into from
Oct 1, 2021

Conversation

TinaHeiligers
Copy link
Contributor

Follow up to #113291.
Handles annotating remaining beats with categories.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 Feature:Unified Integrations Unified Integrations view feature labels Sep 30, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review September 30, 2021 22:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

lukeelmers
lukeelmers approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to the Fleet team as to whether the categories have been correctly applied, but the code LGTM.

@thomasneirynck
Copy link
Contributor

thanks @TinaHeiligers, I pulled this into #113291 locally just to test, and looks good!

@joshdover
Copy link
Contributor

Huge thanks 💯

@thomasneirynck thomasneirynck mentioned this pull request Oct 1, 2021
Closed
63 tasks
@TinaHeiligers TinaHeiligers added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 1, 2021
@TinaHeiligers TinaHeiligers enabled auto-merge (squash) October 1, 2021 14:59
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit a75003d into elastic:master Oct 1, 2021
@TinaHeiligers TinaHeiligers deleted the home-integrations/add-beats-annotations branch October 1, 2021 17:05
@kibanamachine kibanamachine mentioned this pull request Oct 1, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2021
@TinaHeiligers @kibanamachine
Annotates beats tutorials with custom integration categories (elastic…
b3f5906 
…#113565)
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 1, 2021
@kibanamachine @TinaHeiligers
Annotates beats tutorials with custom integration categories (#113565) (
f730038 
#113652)

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TinaHeiligers @elasticmachine @thomasneirynck @joshdover @kibanamachine @pgayvallet @lukeelmers