Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Visualization] Get rid of saved object loader and use savedObjectClient resolve (#113121) #114442

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

VladLasitsa
Copy link
Contributor

Backports the following commits to 7.x:

…ent resolve (elastic#113121)

* First step: create saved_visualize_utils, starting use new get/save methods

* Use new util methods in embeddable

* move findListItem in utils

* some clean up

* clean up

* Some fixes

* Fix saved object tags

* Some types fixes

* Fix unit tests

* Clean up code

* Add unit tests for new utils

* Fix lint

* Fix tagging

* Add unit tests

* Some fixes

* Clean up code

* Fix lint

* Fix types

* put new methods in start contract

* Fix imports

* Fix lint

* Fix comments

* Fix lint

* Fix CI

* use local url instead of full path

* Fix unit test

* Some clean up

* Fix nits

* fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@VladLasitsa VladLasitsa enabled auto-merge (squash) October 11, 2021 09:00
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 107 108 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
visualizations 257 286 +29

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 72.6KB 72.7KB +84.0B
visualize 51.9KB 53.1KB +1.2KB
total +1.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
visualizations 15 16 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 33.0KB 39.0KB +6.0KB
visualize 16.0KB 15.9KB -47.0B
total +6.0KB
Unknown metric groups

API count

id before after diff
visualizations 275 304 +29

References to deprecated APIs

id before after diff
visualizations 104 102 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit 155d3c7 into elastic:7.x Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants