Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] filter types (#111269) #114447

Merged
merged 9 commits into from
Oct 13, 2021
Merged

[7.x] filter types (#111269) #114447

merged 9 commits into from
Oct 13, 2021

Conversation

ppisljar
Copy link
Member

Backports the following commits to 7.x:

@ppisljar
handling references for kibana_context and get_index_pattern expressi…
481def9 
…on functions (elastic#95224)

# Conflicts:
#	src/plugins/data/server/search/search_service.ts
@ppisljar ppisljar enabled auto-merge (squash) October 11, 2021 09:06
@ppisljar ppisljar mentioned this pull request Oct 11, 2021
Closed
@shahzad31
Copy link
Contributor

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

still security solution cypress tests fail with this:

   │ proc [cypress]         ✓ creates a "ip" list from an uploaded file (7162ms)
   │ proc [kibana]   log   [18:25:17.877] [info][plugins][routes][security] Logging in with provider "basic" (basic)
   │ proc [kibana]   log   [18:25:21.400] [error][fleet][plugins] Error: Not Found
   │ proc [kibana]     at Function.createGenericNotFoundError (/dev/shm/workspace/kibana-build-2/src/core/server/saved_objects/service/lib/errors.js:128:35)
   │ proc [kibana]     at SavedObjectsRepository.get (/dev/shm/workspace/kibana-build-2/src/core/server/saved_objects/service/lib/repository.js:1085:46)
   │ proc [kibana]     at runMicrotasks (<anonymous>)
   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:95:5)
   │ proc [kibana]     at SavedObjectsClient.get (/dev/shm/workspace/kibana-build-2/src/core/server/saved_objects/service/saved_objects_client.js:116:12)
   │ proc [kibana]     at EncryptedSavedObjectsClientWrapper.get (/dev/shm/workspace/kibana-build-2/x-pack/plugins/encrypted_saved_objects/server/saved_objects/encrypted_saved_objects_client_wrapper.js:115:59)
   │ proc [kibana]     at SecureSavedObjectsClientWrapper.get (/dev/shm/workspace/kibana-build-2/x-pack/plugins/security/server/saved_objects/secure_saved_objects_client_wrapper.js:313:25)
   │ proc [kibana]     at SpacesSavedObjectsClient.get (/dev/shm/workspace/kibana-build-2/x-pack/plugins/spaces/server/saved_objects/spaces_saved_objects_client.js:195:12)
   │ proc [kibana]     at PackagePolicyService.get (/dev/shm/workspace/kibana-build-2/x-pack/plugins/fleet/server/services/package_policy.js:230:29)
   │ proc [kibana]     at upgradeManagedPackagePolicies (/dev/shm/workspace/kibana-build-2/x-pack/plugins/fleet/server/services/managed_package_policies.js:32:27)
   │ proc [kibana]     at ensurePreconfiguredPackagesAndPolicies (/dev/shm/workspace/kibana-build-2/x-pack/plugins/fleet/server/services/preconfiguration.js:303:5)
   │ proc [kibana]     at createSetupSideEffects (/dev/shm/workspace/kibana-build-2/x-pack/plugins/fleet/server/services/setup.js:82:7)
   │ proc [kibana]     at awaitIfPending (/dev/shm/workspace/kibana-build-2/x-pack/plugins/fleet/server/services/setup_utils.js:38:20)
   │ proc [kibana]     at fleetSetupHandler (/dev/shm/workspace/kibana-build-2/x-pack/plugins/fleet/server/routes/setup/handlers.js:58:25)
   │ proc [kibana]     at Router.handle (/dev/shm/workspace/kibana-build-2/src/core/server/http/router/router.js:163:30)
   │ proc [kibana]     at handler (/dev/shm/workspace/kibana-build-2/src/core/server/http/router/router.js:124:50) {
   │ proc [kibana]   data: null,
   │ proc [kibana]   isBoom: true,
   │ proc [kibana]   isServer: false,
   │ proc [kibana]   output: {
   │ proc [kibana]     statusCode: 404,
   │ proc [kibana]     payload: { statusCode: 404, error: 'Not Found', message: 'Not Found' },
   │ proc [kibana]     headers: {}
   │ proc [kibana]   },
   │ proc [kibana]   [Symbol(SavedObjectsClientErrorCode)]: 'SavedObjectsClient/notFound'

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

cc @elastic/security-solution can you help me figure out what's going on, is this somehow related to this PR ?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1068 1067 -1
data 538 536 -2
dataVisualizer 351 350 -1
fleet 577 576 -1
infra 965 964 -1
inputControlVis 141 140 -1
lens 826 825 -1
lists 321 320 -1
maps 823 822 -1
ml 1684 1683 -1
observability 364 363 -1
securitySolution 2749 2748 -1
timelines 330 329 -1
uptime 661 660 -1
total -15

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/es-query 156 153 -3
data 2825 2820 -5
total -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +8.0B
canvas 1.0MB 1.0MB -3.0B
dataVisualizer 532.7KB 532.9KB +272.0B
fleet 625.9KB 625.9KB -16.0B
infra 938.0KB 938.3KB +274.0B
inputControlVis 89.2KB 89.2KB +38.0B
lens 1.0MB 1.0MB -16.0B
lists 148.2KB 148.2KB -20.0B
maps 2.7MB 2.7MB -16.0B
ml 3.6MB 3.6MB +274.0B
observability 357.7KB 357.7KB +14.0B
securitySolution 4.6MB 4.6MB +289.0B
timelines 239.7KB 240.0KB +274.0B
uptime 567.1KB 567.1KB -16.0B
visTypeVega 1.9MB 1.9MB +8.0B
total +1.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibana 843 845 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 464.9KB 465.1KB +227.0B
Unknown metric groups

API count

id before after diff
@kbn/es-query 208 205 -3
data 3210 3205 -5
total -8

References to deprecated APIs

id before after diff
securitySolution 1008 1007 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 6c34e15 into elastic:7.x Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppisljar @shahzad31 @dominiqueclarke @kibanamachine