Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add File upload #114934

Merged
merged 6 commits into from
Oct 14, 2021
Merged

[Fleet] Add File upload #114934

merged 6 commits into from
Oct 14, 2021

Conversation

thomasneirynck
Copy link
Contributor

Closes #113940

image

@thomasneirynck thomasneirynck added chore Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 labels Oct 14, 2021
@thomasneirynck thomasneirynck marked this pull request as ready for review October 14, 2021 00:29
@thomasneirynck thomasneirynck requested a review from a team as a code owner October 14, 2021 00:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@thomasneirynck thomasneirynck mentioned this pull request Oct 14, 2021
Closed
63 tasks
joshdover
joshdover approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit / question

src/plugins/custom_integrations/common/index.ts Outdated Show resolved Hide resolved
jgowdyelastic
jgowdyelastic approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a nit pick comment, but on the whole LGTM

x-pack/plugins/data_visualizer/server/plugin.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dataVisualizer 80 85 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 532.9KB 532.9KB -4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 8.5KB 9.1KB +525.0B
Unknown metric groups

API count

id before after diff
dataVisualizer 80 85 +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 14, 2021
@thomasneirynck thomasneirynck merged commit dafd9d4 into elastic:master Oct 14, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2021
@thomasneirynck @kibanamachine
[Fleet] Add File upload (elastic#114934)
cabb8a6
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 14, 2021
@kibanamachine @thomasneirynck
[Fleet] Add File upload (#114934) (#115061)
317b019 
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@joshdover joshdover joshdover approved these changes

@kpollich kpollich Awaiting requested review from kpollich

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Add cards for linking to file upload pages
5 participants
@thomasneirynck @elasticmachine @kibanamachine @joshdover @jgowdyelastic