Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register kibana_user role deprecations in UA. #115573

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Register kibana_user role deprecations in UA. #115573

merged 1 commit into from
Oct 20, 2021

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Oct 19, 2021 •
edited
Loading

Summary

Forward-port of #115020 since kibana_user role won't be removed in 8.0.

Screenshots

UI/UX of Upgrade Assistant is a bit weird on master, but I assume it will improve before we enable it (it's disabled today, I tweaked source locally to make it appear).

screen_1

screen_2

screen_3

Fixes: #42853

@azasypkin azasypkin added deprecation_warnings backport:skip This commit does not require backporting buildkite-ci Feature:Security/Authorization Platform Security - Authorization release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Oct 19, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
security 51 54 +3

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
security 7 8 +1
Unknown metric groups

API count

id before after diff
security 113 116 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin marked this pull request as ready for review October 19, 2021 16:37
@azasypkin azasypkin requested a review from a team as a code owner October 19, 2021 16:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

jportner
jportner approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't think we need to worry too much about how this appears in the upgrade assistant yet; we'll cross that bridge in 8.x 👍

@azasypkin azasypkin merged commit 5894d75 into elastic:master Oct 20, 2021
@azasypkin azasypkin deleted the issue-xxx-kibana-admin branch October 20, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting buildkite-ci deprecation_warnings Feature:Security/Authorization Platform Security - Authorization release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Assistant - change kibana_user to kibana_admin
4 participants
@azasypkin @kibanamachine @elasticmachine @jportner