Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add deprecation warning about rule preview permissions #116878

Merged
merged 10 commits into from
Nov 2, 2021

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Oct 30, 2021

Summary

As part of improving the detection engine's rule preview functionality, we're going to start writing "preview" alerts to a new index. This index is analogous to the signals index in most ways (mappings, ILM, etc.), but in order for this new functionality to work users will need to be able to read from this index.

In addition to noting these new requirements in the 8.0 documentation, we're also adding this deprecation warning in 7.16 so that users have an opportunity for a seamless upgrade.

Screenshots from Upgrade Assistant

Screen Shot 2021-10-29 at 10 38 36 PM

Screen Shot 2021-10-29 at 10 46 04 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

rylnd added 3 commits October 29, 2021 18:01
* Alert users that they need a new privilege for rule preview in 8.0
* If we find existing roles that have read access to the signals index,
  list their names for the user.
@rylnd rylnd added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0 labels Oct 30, 2021
@rylnd rylnd requested a review from jmikell821 October 30, 2021 03:47
@rylnd
Copy link
Contributor Author

rylnd commented Oct 30, 2021

@jmikell821 I pinged you for the copy here, and for the followup on the corresponding 8.0 documentation changes.

@rylnd
Copy link
Contributor Author

rylnd commented Oct 30, 2021

@elasticmachine merge upstream

@rylnd
Copy link
Contributor Author

rylnd commented Nov 1, 2021

@elasticmachine merge upstream

kibanamachine and others added 2 commits November 1, 2021 09:57
Use i18n interpolation instead of a template literal.
@rylnd
Copy link
Contributor Author

rylnd commented Nov 1, 2021

@elasticmachine merge upstream

@rylnd rylnd self-assigned this Nov 1, 2021
@rylnd rylnd marked this pull request as ready for review November 1, 2021 20:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@rylnd rylnd requested a review from a team November 1, 2021 21:08
Copy link
Contributor

@marshallmain marshallmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending updates to unit tests

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rylnd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants