Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Show callout when EPR unavailable #117598

Merged
merged 16 commits into from
Nov 9, 2021
Merged

[Fleet] Show callout when EPR unavailable #117598

merged 16 commits into from
Nov 9, 2021

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Nov 4, 2021 •
edited
Loading

Summary

Closes #115564

Show callout on the integration page when EPR is unavailable.

image

How to test:

  • make sure EPR is unavailble. Easiest way to do this is by add an entry to your etc/host file for https://epr-snapshot.elastic.co to loopback when testing this locally from main branch. (e.g. 127.0.0.1 epr-snapshot.elastic.co
    )
  • navigate to Integrations page

Checklist

Delete any items that are not applicable to this PR.

@thomasneirynck thomasneirynck added the release_note:skip Skip the PR/issue when compiling release notes label Nov 4, 2021
@thomasneirynck thomasneirynck changed the title Fleet/epr unavailable [Fleet] Show callout when EPR unavailable Nov 4, 2021
@thomasneirynck thomasneirynck added Feature:Unified Integrations Unified Integrations view feature v7.16.0 v8.0.0 v8.1.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 4, 2021
@thomasneirynck thomasneirynck marked this pull request as ready for review November 4, 2021 21:19
@thomasneirynck thomasneirynck requested review from a team as code owners November 4, 2021 21:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

lukeelmers
lukeelmers approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclinks lgtm

joshdover
joshdover reviewed Nov 5, 2021
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, would like to discuss the copy before merging.

joshdover
joshdover reviewed Nov 5, 2021
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok actually one change 😄

...gins/fleet/public/applications/integrations/sections/epm/screens/home/available_packages.tsx Outdated Show resolved Hide resolved
thomasneirynck
thomasneirynck commented Nov 8, 2021
View reviewed changes
x-pack/plugins/fleet/server/errors/handlers.ts
// 4xx/5xx's from EPR
return 500;
}
if (error instanceof RegistryConnectionError || error instanceof RegistryError) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding explicit check on both, even though RegistryConnectionError subclasses from RegistryError. It may help as in-code documentation, and doesn't tie it as much to class-hierarchy.

nchaulet
nchaulet approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@thomasneirynck thomasneirynck added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 615.1KB 616.8KB +1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 267.5KB 267.7KB +167.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit b122a23 into elastic:main Nov 9, 2021
@kibanamachine kibanamachine mentioned this pull request Nov 9, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
@thomasneirynck @kibanamachine
[Fleet] Show callout when EPR unavailable (elastic#117598)
1264b78
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
@thomasneirynck @kibanamachine
[Fleet] Show callout when EPR unavailable (elastic#117598)
6389bd6
@kibanamachine kibanamachine mentioned this pull request Nov 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 10, 2021
@kibanamachine @thomasneirynck
[7.16] [Fleet] Show callout when EPR unavailable (#117598) (#118082)
7ca4a3a 
* [Fleet] Show callout when EPR unavailable (#117598)

* Update src/core/public/doc_links/doc_links_service.ts

Co-authored-by: Thomas Neirynck <thomas@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 10, 2021
@kibanamachine @thomasneirynck
[8.0] [Fleet] Show callout when EPR unavailable (#117598) (#118081)
e936e4d 
* [Fleet] Show callout when EPR unavailable (#117598)

* Update src/core/public/doc_links/doc_links_service.ts

Co-authored-by: Thomas Neirynck <thomas@elastic.co>
@juliaElastic juliaElastic mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover left review comments

@lukeelmers lukeelmers lukeelmers approved these changes

@nchaulet nchaulet nchaulet approved these changes

@kpollich kpollich Awaiting requested review from kpollich

@lcawl lcawl Awaiting requested review from lcawl

@dedemorton dedemorton Awaiting requested review from dedemorton

@gchaps gchaps Awaiting requested review from gchaps

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Handle scenario where EPR is not accessible
8 participants
@thomasneirynck @elasticmachine @kibanamachine @nchaulet @lukeelmers @joshdover @dedemorton @gchaps