Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY] Enables normal mode for percentage charts #120197

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Dec 2, 2021

Summary

Part of #118525 for 8.0+. The 7.16.1 PR is here #119582.
This PR is using the computeRatioByGroups function of EC library to allow users creating unstacked percentage charts.
Until now, every time a user wanted to create a percentage chart, the mode was changing automatically to stacked. I removed this functionality and now we allow the users to create this kind of charts.
image

image

Checklist

@stratoula stratoula added 8.0.0 release_note:fix v8.1.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed 8.0.0 labels Dec 2, 2021
@stratoula stratoula marked this pull request as ready for review December 2, 2021 11:43
@stratoula stratoula requested a review from a team as a code owner December 2, 2021 11:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeXy 60.5KB 60.4KB -116.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.0MB 5.0MB +991.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra
Copy link
Contributor

mbondyra commented Dec 6, 2021

Tested on FF, works as expected 🆗

@stratoula stratoula merged commit cb18aed into elastic:main Dec 6, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 6, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 6, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:XYAxis XY-Axis charts (bar, area, line) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants