Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] term join in produce help #120238

Merged
merged 10 commits into from
May 16, 2022
Merged

[Maps] term join in produce help #120238

merged 10 commits into from
May 16, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 2, 2021 •
edited
Loading

Add in-product help for term join

Screen Shot 2022-05-16 at 7 16 59 AM

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Dec 2, 2021
@nreese nreese requested review from a team as code owners December 2, 2021 16:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

afharo
afharo approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doclinks changes LGTM

thomasneirynck
thomasneirynck approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

Discussed adding a little infographic that shows that is going on.

e.g.: something along the lines of this
image

^ showing link between geo-data in the layer (left) and a table from the term-agg (right)

@nreese nreese removed the v8.1.0 label Mar 23, 2022
@nreese nreese requested a review from a team as a code owner May 12, 2022 20:42
@nreese nreese added the v8.3.0 label May 12, 2022
@nreese
Copy link
Contributor Author

nreese commented May 16, 2022

@elasticmachine merge upstream

gchaps
gchaps approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 804 805 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB +2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 300.2KB 300.3KB +67.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit ffc515b into elastic:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@afharo afharo afharo approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nreese @elasticmachine @kibana-ci @thomasneirynck @afharo @gchaps @kibanamachine