Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Move split_panel component to Console #121283

Merged
merged 8 commits into from
Dec 24, 2021
Merged

[Console] Move split_panel component to Console #121283

merged 8 commits into from
Dec 24, 2021

Conversation

mibragimov
Copy link
Contributor

@mibragimov mibragimov commented Dec 15, 2021 •
edited
Loading

Closes #115595

@mibragimov mibragimov added release_note:enhancement Feature:Console Dev Tools Console Feature Feature:Dev Tools backport:skip This commit does not require backporting v8.1.0 labels Dec 15, 2021
@mibragimov mibragimov self-assigned this Dec 15, 2021
@alexwizp alexwizp requested a review from Kuznietsov December 20, 2021 10:30
Kuznietsov
Kuznietsov suggested changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@Kuznietsov Kuznietsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mibragimov, thanks for your efforts 👍 .
There are some minor changes that need to be performed for consistency. Could you, please, perform them.

src/plugins/console/public/application/components/split_panel/split_panel.test.tsx Outdated Show resolved Hide resolved
src/plugins/console/public/application/containers/editor/editor.tsx Outdated Show resolved Hide resolved
src/plugins/console/public/application/components/split_panel/resizer.tsx Outdated Show resolved Hide resolved
src/plugins/console/public/application/containers/split_panel/panel.tsx Outdated Show resolved Hide resolved
src/plugins/console/public/application/contexts/split_panel_context.tsx Outdated Show resolved Hide resolved
@Kuznietsov
Copy link
Contributor

@elasticmachine merge upstream

Kuznietsov
Kuznietsov suggested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@Kuznietsov Kuznietsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly all the changes have been performed. It has left only two small Nits. I'm sure, you'll address them pretty quickly ))

x-pack/plugins/translations/translations/zh-CN.json Show resolved Hide resolved
x-pack/plugins/translations/translations/ja-JP.json Show resolved Hide resolved
src/plugins/console/public/application/containers/editor/editor.tsx Outdated Show resolved Hide resolved
Kuznietsov
Kuznietsov approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@Kuznietsov Kuznietsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mibragimov, thanks. The code LGTM 👍

@mibragimov mibragimov marked this pull request as ready for review December 22, 2021 12:39
@mibragimov mibragimov requested review from a team as code owners December 22, 2021 12:39
Dosant
Dosant approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app-services LGTM 👍

@Kuznietsov
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
console 158 165 +7
kibanaReact 307 301 -6
total +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaReact 214 210 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 373.9KB 376.2KB +2.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 58.6KB 56.2KB -2.4KB
Unknown metric groups

API count

id before after diff
kibanaReact 239 235 -4

ESLint disabled line counts

id before after diff
console 30 31 +1
kibanaReact 16 15 -1
total -0

Total ESLint disabled count

id before after diff
console 33 34 +1
kibanaReact 24 23 -1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mibragimov

sabarasaba
sabarasaba approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, thanks for patching this up @mibragimov! Just two small things, I think we should use the release_note:skip label since this is just a small refactor. And also, could you add the label of our team to the issue? 🚀

@mibragimov mibragimov added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Dec 24, 2021
@mibragimov mibragimov added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Dec 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@mibragimov mibragimov merged commit 54cc284 into elastic:main Dec 24, 2021
@mibragimov mibragimov deleted the split-panel branch December 24, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuznietsov Kuznietsov Kuznietsov approved these changes

@Dosant Dosant Dosant approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

@vladpro25 vladpro25 Awaiting requested review from vladpro25

Assignees

@mibragimov mibragimov

Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move split_panel component into console
7 participants
@mibragimov @Kuznietsov @kibana-ci @elasticmachine @sabarasaba @Dosant @kibanamachine