Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Reduce deprecated api usage #124059

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jan 28, 2022

Summary

A quick pass at

  • Removing unused deprecated apis
  • Reducing usage of deprecated apis

@mattkime mattkime changed the title address deprecated apis [data views] Reduce deprecated api usage Jan 28, 2022
@mattkime mattkime marked this pull request as ready for review January 28, 2022 21:37
@mattkime mattkime requested review from a team as code owners January 28, 2022 21:37
@mattkime mattkime added v8.1.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServicesSv labels Jan 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Jan 28, 2022
@mattkime
Copy link
Contributor Author

mattkime commented Feb 1, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2770 2763 -7
dataViews 592 600 +8
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewFieldEditor 154.4KB 148.8KB -5.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 449.7KB 449.4KB -300.0B
dataViewFieldEditor 18.9KB 24.4KB +5.5KB
dataViews 38.0KB 37.9KB -49.0B
total +5.1KB
Unknown metric groups

API count

id before after diff
data 3368 3358 -10
dataViews 734 745 +11
total +1

References to deprecated APIs

id before after diff
data 492 488 -4
dataViewEditor 63 45 -18
dataViewFieldEditor 31 25 -6
dataViews 206 182 -24
total -52

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@mattkime mattkime merged commit 934302d into elastic:main Feb 1, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants