Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified observability] Migrate deprecated IndexPattern types #124962

Merged
merged 15 commits into from
Mar 9, 2022
Merged

[Unified observability] Migrate deprecated IndexPattern types #124962

merged 15 commits into from
Mar 9, 2022

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Feb 8, 2022 •
edited
Loading

Closes #122318

Remove references to all IndexPattern and associated types from the observability plugin.

@afgomez afgomez force-pushed the 122318-index-pattern-deprecated branch from ffe23de to 3a09295 Compare February 10, 2022 16:02
@afgomez afgomez marked this pull request as ready for review February 10, 2022 16:15
@afgomez afgomez requested review from a team as code owners February 10, 2022 16:15
@afgomez afgomez added release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability v8.2.0 labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

@afgomez afgomez force-pushed the 122318-index-pattern-deprecated branch from 3a09295 to 849f6f5 Compare February 21, 2022 11:19
@afgomez afgomez force-pushed the 122318-index-pattern-deprecated branch from 849f6f5 to 085fcac Compare February 23, 2022 09:46
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@estermv
Copy link
Contributor

estermv commented Feb 23, 2022

@elasticmachine merge upstream

estermv
estermv approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@afgomez
Copy link
Contributor Author

afgomez commented Mar 2, 2022

@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

@afgomez
Copy link
Contributor Author

afgomez commented Mar 7, 2022

@elasticmachine merge upstream

@afgomez
Copy link
Contributor Author

afgomez commented Mar 8, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 395.6KB 395.3KB -280.0B
uptime 743.4KB 743.3KB -16.0B
total -296.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 87.5KB 87.5KB -16.0B
Unknown metric groups

References to deprecated APIs

id before after diff
observability 118 0 -118

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 299b21b into elastic:main Mar 9, 2022
@afgomez afgomez deleted the 122318-index-pattern-deprecated branch March 9, 2022 11:24
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 11, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

6 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@smith smith added v9.0.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 22, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 23, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124962 or prevent reminders by adding the backport:skip label.

@smith smith added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. v9.0.0 labels Mar 23, 2022
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@estermv estermv estermv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unified Observability] Replace deprecated IndexPattern types
8 participants
@afgomez @elasticmachine @estermv @kibana-ci @kibanamachine @dominiqueclarke @smith @tylersmalley