[Security Solutions] Reduces timeouts from 10 minutes per test down to 2 minutes and changes log.error to log.debug to avoid spamming #125432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es one log.error to log.debug to avoid spamming cloud servers
FrankHassanabad
added
release_note:skip
MadameSheema
approved these changes
Feb 11, 2022
FrankHassanabad
added
the
auto-backport
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2022
…es one log.error to log.debug to avoid spamming cloud servers (elastic#125432) ## Summary Fixes elastic#125319 Reduces timeouts from 10 minutes per test down to 2 minutes and changes log.error to log.debug to avoid spamming I test this by making a failing test here: ``` x-pack/test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` By increasing `await waitForSignalsToBePresent(supertest, log, 4, [id]);` from `4` to `5`....Then I watched the logs and timed it to ensure it doesn't take 2 minutes. I did this by running the server: ```sh node scripts/functional_tests_server.js --config test/detection_engine_api_integration/security_and_spaces/config.ts ``` And then running the client: ```sh node scripts/functional_test_runner.js --config test/detection_engine_api_integration/security_and_spaces/config.ts --include test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` If we start to see flake again on the regular build servers we might have to slightly increase this number again. If this doesn't allow failing servers to fully complete we might need to also decrease this number further or we might need to make this more configurable. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6d88579)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2022
…es one log.error to log.debug to avoid spamming cloud servers (elastic#125432) ## Summary Fixes elastic#125319 Reduces timeouts from 10 minutes per test down to 2 minutes and changes log.error to log.debug to avoid spamming I test this by making a failing test here: ``` x-pack/test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` By increasing `await waitForSignalsToBePresent(supertest, log, 4, [id]);` from `4` to `5`....Then I watched the logs and timed it to ensure it doesn't take 2 minutes. I did this by running the server: ```sh node scripts/functional_tests_server.js --config test/detection_engine_api_integration/security_and_spaces/config.ts ``` And then running the client: ```sh node scripts/functional_test_runner.js --config test/detection_engine_api_integration/security_and_spaces/config.ts --include test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` If we start to see flake again on the regular build servers we might have to slightly increase this number again. If this doesn't allow failing servers to fully complete we might need to also decrease this number further or we might need to make this more configurable. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6d88579)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2022
…es one log.error to log.debug to avoid spamming cloud servers (#125432) (#125441) ## Summary Fixes #125319 Reduces timeouts from 10 minutes per test down to 2 minutes and changes log.error to log.debug to avoid spamming I test this by making a failing test here: ``` x-pack/test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` By increasing `await waitForSignalsToBePresent(supertest, log, 4, [id]);` from `4` to `5`....Then I watched the logs and timed it to ensure it doesn't take 2 minutes. I did this by running the server: ```sh node scripts/functional_tests_server.js --config test/detection_engine_api_integration/security_and_spaces/config.ts ``` And then running the client: ```sh node scripts/functional_test_runner.js --config test/detection_engine_api_integration/security_and_spaces/config.ts --include test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` If we start to see flake again on the regular build servers we might have to slightly increase this number again. If this doesn't allow failing servers to fully complete we might need to also decrease this number further or we might need to make this more configurable. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6d88579) Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2022
…es one log.error to log.debug to avoid spamming cloud servers (#125432) (#125442) ## Summary Fixes #125319 Reduces timeouts from 10 minutes per test down to 2 minutes and changes log.error to log.debug to avoid spamming I test this by making a failing test here: ``` x-pack/test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` By increasing `await waitForSignalsToBePresent(supertest, log, 4, [id]);` from `4` to `5`....Then I watched the logs and timed it to ensure it doesn't take 2 minutes. I did this by running the server: ```sh node scripts/functional_tests_server.js --config test/detection_engine_api_integration/security_and_spaces/config.ts ``` And then running the client: ```sh node scripts/functional_test_runner.js --config test/detection_engine_api_integration/security_and_spaces/config.ts --include test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts ``` If we start to see flake again on the regular build servers we might have to slightly increase this number again. If this doesn't allow failing servers to fully complete we might need to also decrease this number further or we might need to make this more configurable. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6d88579) Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #125319
Reduces timeouts from 10 minutes per test down to 2 minutes and changes log.error to log.debug to avoid spamming
I test this by making a failing test here:
By increasing
await waitForSignalsToBePresent(supertest, log, 4, [id]);from4to5....Then I watched the logs and timed it to ensure it doesn't take 2 minutes.I did this by running the server:
And then running the client:
If we start to see flake again on the regular build servers we might have to slightly increase this number again. If this doesn't allow failing servers to fully complete we might need to also decrease this number further or we might need to make this more configurable.
Checklist
Delete any items that are not applicable to this PR.