Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Snapshot and Restore tests to use test user #126011

Merged
merged 9 commits into from
Feb 24, 2022
Merged

Migrated Snapshot and Restore tests to use test user #126011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da8f83b
Migrated Snapshot and Restore tests to use test user.
cuff-links Feb 18, 2022
ec682e2
added another permission to address unauthorized failure.
cuff-links Feb 18, 2022
fbfe31f
Added metadata perms for kibana administration.
cuff-links Feb 21, 2022
7791357
Testing out different permissions.
Feb 22, 2022
340c5b1
Edited test to not refresh page after role is set. Causing errors.
Feb 22, 2022
6421c52
Merge branch 'main' into Migrate_Snapshot_Restore_Tests_To_Use_TestUser
kibanamachine Feb 22, 2022
da598bb
Adjusted perms per documentation.
Feb 24, 2022
45fe70e
Merge branch 'Migrate_Snapshot_Restore_Tests_To_Use_TestUser' of gith…
Feb 24, 2022
bf2450f
Addded link to the documentation specifying the permissions needed fo…
Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions x-pack/test/functional/apps/snapshot_restore/home_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const pageObjects = getPageObjects(['common', 'snapshotRestore']);
const log = getService('log');
const es = getService('es');
const security = getService('security');

describe('Home page', function () {
before(async () => {
await security.testUser.setRoles(['snapshot_restore_user'], false);
await pageObjects.common.navigateToApp('snapshotRestore');
});

Expand Down Expand Up @@ -46,9 +48,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

it('cleanup repository', async () => {
await pageObjects.snapshotRestore.viewRepositoryDetails('my-repository');
await pageObjects.common.sleep(25000);
const cleanupResponse = await pageObjects.snapshotRestore.performRepositoryCleanup();
await pageObjects.common.sleep(25000);
expect(cleanupResponse).to.contain('results');
expect(cleanupResponse).to.contain('deleted_bytes');
expect(cleanupResponse).to.contain('deleted_blobs');
Expand All @@ -57,6 +57,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await es.snapshot.deleteRepository({
name: 'my-repository',
});
await security.testUser.restoreDefaults();
});
});
});
Expand Down
19 changes: 19 additions & 0 deletions x-pack/test/functional/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,25 @@ export default async function ({ readConfigFile }) {
},
],
},
// https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-register-repository.html#snapshot-repo-prereqs
snapshot_restore_user: {
elasticsearch: {
cluster: [
'monitor',
'manage_slm',
'cluster:admin/snapshot',
'cluster:admin/repository',
],
},
kibana: [
{
feature: {
advancedSettings: ['read'],
},
spaces: ['*'],
},
],
},

ingest_pipelines_user: {
elasticsearch: {
Expand Down
5 changes: 4 additions & 1 deletion x-pack/test/functional/page_objects/snapshot_restore_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,15 @@ export function SnapshotRestorePageProvider({ getService }: FtrProviderContext)
const repoToView = repos.filter((r) => (r.repoName = name))[0];
await repoToView.repoLink.click();
}
await retry.waitForWithTimeout(`Repo title should be ${name}`, 10000, async () => {
await retry.waitForWithTimeout(`Repo title should be ${name}`, 25000, async () => {
return (await testSubjects.getVisibleText('title')) === name;
});
},
async performRepositoryCleanup() {
await testSubjects.click('cleanupRepositoryButton');
await retry.waitForWithTimeout(`wait for code block to be visible`, 25000, async () => {
return await testSubjects.isDisplayed('cleanupCodeBlock');
});
return await testSubjects.getVisibleText('cleanupCodeBlock');
},
};
Expand Down