[Infrastructure UI] Optimization for Metric Threshold Rule for 7.17 #126545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:Metrics UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
…timization-for-metric-threshold-rule-7-17
jasonrhodes
reviewed
Mar 7, 2022
x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_alert.ts
Show resolved
Hide resolved
This reverts commit 9f73db7.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
jasonrhodes
approved these changes
Mar 8, 2022
|
I like the sound of this fix and the performance improvement |
simianhacker
deleted the
issue-126508-optimization-for-metric-threshold-rule-7-17
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #126508 by refactoring all the reduces in favor of
for/of. For 10K hosts, this rule would take ~23 seconds to execute, with this change it brings that down to ~6 seconds.