Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Span link #126630

Merged
merged 68 commits into from
May 16, 2022
Merged

[APM] Span link #126630

merged 68 commits into from
May 16, 2022

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Mar 1, 2022 •
edited
Loading

closes #125546
closes #126667

span.links.mov

@cauemarcondes cauemarcondes force-pushed the apm-span-links-synthtrace branch 2 times, most recently from 3cbde33 to 1abdba2 Compare April 18, 2022 18:17
@cauemarcondes cauemarcondes added release_note:feature Makes this part of the condensed release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 labels Apr 25, 2022
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

dgieselaar
dgieselaar reviewed May 11, 2022
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be close now. Code looks great! Just a few more questions/remarks.

packages/elastic-apm-synthtrace/src/scripts/examples/04_span_links.ts Outdated Show resolved Hide resolved
packages/elastic-apm-synthtrace/src/scripts/examples/04_span_links.ts Outdated Show resolved Hide resolved
packages/elastic-apm-synthtrace/src/scripts/examples/04_span_links.ts Outdated Show resolved Hide resolved
...m/ftr_e2e/cypress/integration/read_only_user/transaction_details/generate_span_links_data.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/server/routes/span_links/get_span_links_details.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/span_links_tab_content.tsx Outdated Show resolved Hide resolved
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

dgieselaar
dgieselaar approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the code/tests are at a good point now, thanks Caue! I would like to see some of the suggested name changes but approving ahead of time.

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #19 / APM API tests trial apm_mappings_only_8.0.0 Sorted and filtered services "before all" hook in "Sorted and filtered services"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1181 1186 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +8.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
apm 50 51 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit d3b9f32 into elastic:main May 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2022
@cauemarcondes cauemarcondes deleted the apm-span-links-synthtrace branch May 16, 2022 18:40
@kibanamachine
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 126630

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz left review comments

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Support span links [APM] [Span link] Generate test data with span links
7 participants
@cauemarcondes @elasticmachine @dgieselaar @kibana-ci @kibanamachine @Mpdreamz @boriskirov