-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Span link #126630
[APM] Span link #126630
Conversation
0de47b8
to
f5ac87d
Compare
packages/elastic-apm-synthtrace/src/scripts/examples/04_span_links.ts
Outdated
Show resolved
Hide resolved
3cbde33
to
1abdba2
Compare
1abdba2
to
b09bbc5
Compare
…kibana into apm-span-links-synthtrace
59d9440
to
1a1672b
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be close now. Code looks great! Just a few more questions/remarks.
packages/elastic-apm-synthtrace/src/scripts/examples/04_span_links.ts
Outdated
Show resolved
Hide resolved
packages/elastic-apm-synthtrace/src/scripts/examples/04_span_links.ts
Outdated
Show resolved
Hide resolved
packages/elastic-apm-synthtrace/src/scripts/examples/04_span_links.ts
Outdated
Show resolved
Hide resolved
...m/ftr_e2e/cypress/integration/read_only_user/transaction_details/generate_span_links_data.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/routes/span_links/get_span_links_details.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/span_links/span_links_tab_content.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the code/tests are at a good point now, thanks Caue! I would like to see some of the suggested name changes but approving ahead of time.
@elasticmachine merge upstream |
…kibana into apm-span-links-synthtrace
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
⚪ Backport skippedThe pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
closes #125546
closes #126667
span.links.mov