-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bazel] validate packages/BUILD.bazel in CI #127241
[bazel] validate packages/BUILD.bazel in CI #127241
Conversation
f3c4119
to
1dd300b
Compare
1818f30
to
65876b2
Compare
65876b2
to
f406f8f
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Windows this replaces all packages from //packages/
-> //packages\
…ate-package-build-file
Thanks @jbudz, paths are annoying but I think I've fixed this. |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Any counts in public APIs
Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
(cherry picked from commit 9871111)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
With #127095 we started generating the
packages/BUILD.bazel
file. This only happens when you generate a new package though, and can cause unexpected updates when a user generates a package after others have manually updated the file.To ensure that this file is always up-to-date with the state of the repo and sorted correctly this PR adds
node scripts/generate packages_build_manifest
. This new command just regenerates thepackages/BUILD.bazel
file based on the packages discovered. This command also supports a--validate
flag which will be run on CI to fail CI when the file is outdated:Additionally, this PR fixes a bug with the default
@npm//
deps includes in generated BUILD.bazel file that @clintandrewhall caught as he experimented with this new generator, improves the help text for the--web
option.