Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Visualizer: Migrate IndexPattern service usage to DataView service #127752

Merged
merged 6 commits into from
Mar 17, 2022

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Mar 15, 2022

Summary

The DataViews service has been broken out of the data plugin into the data_views plugin. This PR replaces all usage of the now deprecated indexPatterns API in the data_visualizer plugin with the DataView API.

As well as updating imports, most of the uses of indexPattern type parameter and function names have been replaced to dataView.

Note that related changes to functional test function names have been kept to a minimum to reduce the code churn in this PR.

Also fixed a bug in the action to Lens for keyword fields, which was using the now unsupported bar_horizontal seriesType.

Part of #124063 and #124092

Checklist

@peteharverson peteharverson added review :ml technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer backport:skip This commit does not require backporting v8.2.0 labels Mar 15, 2022
@peteharverson peteharverson self-assigned this Mar 15, 2022
@peteharverson peteharverson requested review from a team as code owners March 15, 2022 13:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataDiscovery.team.lgtm() === true, just a code review

@qn895
Copy link
Member

qn895 commented Mar 15, 2022

Tested file upload, index data visualizer, and Discover field statistics and LGTM 🎉

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member

qn895 commented Mar 16, 2022

Tested and LGTM

@peteharverson peteharverson force-pushed the data-vis-data-views-service branch from 7a4b065 to 55a3649 Compare March 16, 2022 16:15
@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 539.0KB 538.5KB -470.0B
discover 380.3KB 380.3KB -8.0B
total -478.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 16.7KB 16.7KB -4.0B
Unknown metric groups

References to deprecated APIs

id before after diff
dataVisualizer 212 0 -212

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@peteharverson peteharverson merged commit c22fcd4 into elastic:main Mar 17, 2022
@peteharverson peteharverson deleted the data-vis-data-views-service branch March 17, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes review technical debt Improvement of the software architecture and operational architecture v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants