-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Visualizer: Migrate IndexPattern service usage to DataView service #127752
[ML] Data Visualizer: Migrate IndexPattern service usage to DataView service #127752
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataDiscovery.team.lgtm() === true, just a code review
Tested file upload, index data visualizer, and Discover field statistics and LGTM 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested and LGTM |
7a4b065
to
55a3649
Compare
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
The DataViews service has been broken out of the data plugin into the
data_views
plugin. This PR replaces all usage of the now deprecatedindexPatterns
API in thedata_visualizer
plugin with theDataView
API.As well as updating imports, most of the uses of
indexPattern
type parameter and function names have been replaced todataView
.Note that related changes to functional test function names have been kept to a minimum to reduce the code churn in this PR.
Also fixed a bug in the action to Lens for keyword fields, which was using the now unsupported
bar_horizontal
seriesType
.Part of #124063 and #124092
Checklist