reload on global fetch event and emit vis:ready #12805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Feature:Visualizations
|
CI seems to be on the frutz across the board, not just this PR. jenkins, test this |
|
closes #12782. |
There was a problem hiding this comment.
This solves:
- adding a saved-search after a visualizaiton now works correctly
- pressing the magnifier glass in the query-bar now triggers a refresh
I did notice that auto-refresh (e.g. every 5 seconds) on the dashboard does not work. Not sure if this was broken before, or just with this PR.
Auto-refresh is also broken on the Visualize page.
|
Merging this. Will track auto-refresh issue separately. |
|
tracking dashboard/viz refresh separately: #12811 |
|
ah crap, for auto refresh i see one line of code got lost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vis:ready should be emitted when visualize is ready not when rendering is complete