-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] drag and drop functionality for annotations #128432
Conversation
c10b0b2
to
3792966
Compare
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
043ebd5
to
2202f5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Might be helpful to track the refactor in a follow-up tech-debt issue.
Thank you Andrew! Issue added: #128506 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and works like a charm!
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Implements reorder & duplicating dimension in the group for annotations.
This is a code that will be immediately refactored in the next iteration but I want to squeeze it in for 8.2.
As always, dropping to empty button duplicates the dimension.
Reordering doesn't influence visualization in almost no way, except for the order in the tooltips if the annotations share the same exact timestamp. (see picture)
Mar-24-2022.14-23-53.mp4
I've also fixed a little issue- tooltip's times are now sorted:
before the position in the tooltip depended on position in annotations[] array.
Now it depends on timestamp (first go first) and then on the position in the array.