Unit Tests for new o11y rules page #128576
Conversation
|
@elasticmachine merge upstream |
mgiota
added
Team: Actionable Observability - DEPRECATED
|
@elasticmachine merge upstream |
mgiota
added
the
auto-backport
| describe('empty RulesPage with show only capability', () => { | ||
| let wrapper: ReactWrapper<any>; | ||
| async function setup() { | ||
| const rulesState = { |
| describe('empty RulesPage', () => { | ||
| let wrapper: ReactWrapper<any>; | ||
| async function setup() { | ||
| const rulesState = { |
There was a problem hiding this comment.
Would you please use the Rule State type for this variable https://github.com/elastic/kibana/pull/128576/files#diff-f3577bd6740c5a14c816d10e3104210e7598807d70a4953e60d28e513ebfe559R89
| }, | ||
| ]; | ||
|
|
||
| const rulesState = { |
| await nextTick(); | ||
| wrapper.update(); | ||
| }); | ||
| expect(wrapper.find(RulesTable)).toHaveLength(0); |
There was a problem hiding this comment.
What does toHaveLength(0) mean for the Rules Table? it seems to be checking of existence why not use .exists() for example?
Don't we need a kind of selector to do so?
There was a problem hiding this comment.
@fkanout I can do expect(wrapper.find(RulesTable).exists()).toBe(false);
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mgiota |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
mgiota
removed
auto-backport
* tests for rules page * mock useKibana and useBreadcrubms * mock useFetchRules * rules page scenarios * temp * mock usePluginContext and useLoadRuleTypes * fix typescript errors * fix Jest did not exit one second after the test run has completed warning * add more tests to the empty rules page scenario * fix typescript error * render documentation link * empty RulesPage with show only capability * rules page with items * RulesPage with items and show only capability * remove disabled items (I need to implement it later on) * refactoring * update documentation link * add types to the ruleState Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #127440
Covers following basic scenarios:
Note: These tests are a starting point and can be extended to cover more scenarios