Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Better a11y for page header #129789

Merged
merged 3 commits into from
Apr 11, 2022
Merged

[Discover] Better a11y for page header #129789

merged 3 commits into from
Apr 11, 2022

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Apr 7, 2022 •
edited
Loading

Summary

Fix #123297

Discover's h1 heading (screenreader only) now contains

  • "Discover - Search not yet saved" when not viewing a saved search
  • "Discover - {saved-search-title}" when viewing a saved search

Screen Shot 2022-04-07 at 1 46 08 PM

Screen Shot 2022-04-07 at 1 46 36 PM

Checklist

Delete any items that are not applicable to this PR.

@drewdaemon drewdaemon added Feature:Discover Discover Application auto-backport Deprecated - use backport:version if exact versions are needed Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week v8.2.0 ui-copy Review of UI copy with docs team is recommended v8.3.0 labels Apr 7, 2022
@drewdaemon drewdaemon requested a review from a team as a code owner April 7, 2022 18:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@drewdaemon drewdaemon added the release_note:skip Skip the PR/issue when compiling release notes label Apr 7, 2022
kertal
kertal approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on fix-it-week-🔥, Andrew! Tested locally, works as expected. Merci!

@kertal
Copy link
Member

kertal commented Apr 11, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 400.4KB 400.6KB +245.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 6542dc1 into elastic:main Apr 11, 2022
@kibanamachine kibanamachine mentioned this pull request Apr 11, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 11, 2022
@drewdaemon
[Discover] Better a11y for page header (#129789)
0439e97 
(cherry picked from commit 6542dc1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 11, 2022
@kibanamachine @drewdaemon
[Discover] Better a11y for page header (#129789) (#129885)
818fa1a 
(cherry picked from commit 6542dc1)

Co-authored-by: Andrew Tate <andrew.tate@elastic.co>
@jughosta jughosta mentioned this pull request Jul 13, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :DataDiscovery/fix-it-week Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. ui-copy Review of UI copy with docs team is recommended v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Accessibility) - Discover Page - Empty Heading Tags
5 participants
@drewdaemon @elasticmachine @kertal @kibana-ci @kibanamachine